Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deploy jar Java runtime dependency for non-executable targets #19140

Closed
wants to merge 2 commits into from
Closed

Remove deploy jar Java runtime dependency for non-executable targets #19140

wants to merge 2 commits into from

Commits on Aug 3, 2023

  1. Remove deploy jar Java runtime dependency for non-executable targets 

    This allows deploy jars for `java_binary` targets with
`create_executable = False` to compile for target platforms for which no
standalone Java runtime is available (e.g. Android).

Along the way, this removes a redundant check: `runtime.hermetic_files`
is never `None`.
    @fmeum
    fmeum committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    0b3131e View commit details
    Browse the repository at this point in the history

  2. Address review feedback

    @fmeum
    fmeum committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    ef86e66 View commit details
    Browse the repository at this point in the history