Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header missing when compiling with mingw-gcc #19187

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Aug 7, 2023

Fixes this failure:

external/bazel_tools/src/tools/launcher/launcher_maker.cc:77:3: error: 'int64_t' was not declared in this scope
   77 |   int64_t bytes = 0;
      |   ^~~~~~~
external/bazel_tools/src/tools/launcher/launcher_maker.cc:22:1: note: 'int64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   21 | #include "src/main/cpp/util/path_platform.h"
  +++ |+#include <cstdint>
   22 |
external/bazel_tools/src/tools/launcher/launcher_maker.cc:81:5: error: 'bytes' was not declared in this scope
   81 |     bytes += line.length();
      |     ^~~~~
external/bazel_tools/src/tools/launcher/launcher_maker.cc:86:44: error: 'bytes' was not declared in this scope
   86 |   dst.write(reinterpret_cast<const char*>(&bytes), sizeof(bytes));
      |                                            ^~~~~

Fixes bazelbuild/rules_go#3642

Fixes this failure:

```
external/bazel_tools/src/tools/launcher/launcher_maker.cc:77:3: error: 'int64_t' was not declared in this scope
   77 |   int64_t bytes = 0;
      |   ^~~~~~~
external/bazel_tools/src/tools/launcher/launcher_maker.cc:22:1: note: 'int64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   21 | #include "src/main/cpp/util/path_platform.h"
  +++ |+#include <cstdint>
   22 |
external/bazel_tools/src/tools/launcher/launcher_maker.cc:81:5: error: 'bytes' was not declared in this scope
   81 |     bytes += line.length();
      |     ^~~~~
external/bazel_tools/src/tools/launcher/launcher_maker.cc:86:44: error: 'bytes' was not declared in this scope
   86 |   dst.write(reinterpret_cast<const char*>(&bytes), sizeof(bytes));
      |                                            ^~~~~

```
@fmeum fmeum requested a review from hvadehra August 7, 2023 05:49
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Aug 7, 2023
@sgowroji sgowroji added area-Windows Windows-specific issues and feature requests team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Aug 7, 2023
Copy link
Member

@hvadehra hvadehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hvadehra hvadehra added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 7, 2023
@copybara-service copybara-service bot closed this in df21cb8 Aug 7, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 7, 2023
@fmeum fmeum deleted the go-3642 branch August 7, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Windows Windows-specific issues and feature requests team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rules_go is failing with Bazel@HEAD in Windows
3 participants