Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick required commits into 7.0.0-pre.20230810.1rc1 #19298

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Cherry-pick required commits into 7.0.0-pre.20230810.1rc1 #19298

merged 2 commits into from
Aug 22, 2023

Conversation

fweikert
Copy link
Member

@fweikert fweikert commented Aug 22, 2023 •
edited
Loading

@meteorcloudy @fweikert
Select the correct toolchain for Windows arm64 after enabling cc tool…
fe41bda 
…chain resolution.

PiperOrigin-RevId: 555413912
Change-Id: I3ccc0d51973849aaa891dd0944a00432ce3d2cfb
@meteorcloudy @fweikert
Disable using NEON instructions on Windows arm64
8c39828 
Otherwise getting

```
blake3.lib(blake3_dispatch.obj) : error LNK2019: unresolved external symbol blake3_hash_many_neon referenced in function blake3_hash_many
bazel-out\x64_windows-opt\bin\src\main\native\windows\windows_jni.dll : fatal error LNK1120: 1 unresolved externals
```

PiperOrigin-RevId: 555467146
Change-Id: Ib34811467d7f0f6980bfa4976b8d1ba2fb041b16
@fweikert fweikert changed the title Release 7.0.0 pre.20230810.1rc1 Cherry-pick required commits into 7.0.0-pre.20230810.1rc1 Aug 22, 2023
@fweikert fweikert marked this pull request as ready for review August 22, 2023 14:09
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Aug 22, 2023
@meteorcloudy meteorcloudy enabled auto-merge (squash) August 22, 2023 15:33
@meteorcloudy meteorcloudy merged commit 4d157ee into bazelbuild:release-7.0.0-pre.20230810.1rc1 Aug 22, 2023
3 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Aug 22, 2023
copybara-service bot pushed a commit that referenced this pull request Aug 22, 2023
@fweikert
Release 7.0.0-pre.20230810.1 (2023-08-22)
171aae3 
Baseline: c279c7b

Cherry picks:

   + 4d157ee:
     Cherry-pick required commits into 7.0.0-pre.20230810.1rc1
     (#19298)

Initial release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fweikert @meteorcloudy