Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump abseil-cpp to 20230802.0 #19345

Closed
wants to merge 1 commit into from

Conversation

ncaq
Copy link

@ncaq ncaq commented Aug 27, 2023

refer bazel-6.2.1 fails to build with gcc-13 · Issue #18642 · bazelbuild/bazel

I use only GitHub because 20230802.0.tar.gz not found in the mirror. Should be test on abseil-cpp by latest.
Because this version is LTS.

This version build on bazel v6, use BAZEL_CXXOPTS='-std=c++14' bazel build //src:bazel-dev. Because bazel v6 use -std=c++0x by default.

refer [bazel-6.2.1 fails to build with gcc-13 · Issue bazelbuild#18642 · bazelbuild/bazel](bazelbuild#18642)

I use only GitHub because `20230802.0.tar.gz` not found in the mirror.
Should be test on abseil-cpp by latest.
Because this version is LTS.

This version build on bazel v6, use `BAZEL_CXXOPTS='-std=c++14' bazel build //src:bazel-dev`.
Because bazel v6 use `-std=c++0x` by default.
@google-cla
Copy link

google-cla bot commented Aug 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Aug 27, 2023
@ncaq
Copy link
Author

ncaq commented Aug 27, 2023

It seems that if the version of Bazel used for CI is v6, then of course CI will fail.
Is it really necessary to change -std=c++14 to make it succeed with v6?

@ncaq
Copy link
Author

ncaq commented Aug 27, 2023

If the Bazel v6 series is the stable version and it is a requirement to be able to build with it, this can be incorporated after Bazel v7 is stable and it is reflected in CI.
Or change -std=c++14.

@sgowroji sgowroji added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 30, 2023
@sgowroji
Copy link
Member

Hi @ncaq, Could you please sign the CLA?

@sgowroji sgowroji added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Rules-CPP Issues for C++ rules labels Aug 30, 2023
@ncaq
Copy link
Author

ncaq commented Aug 30, 2023

@sgowroji
I did sign in but missed the check update.
I just did.

@sgowroji
Copy link
Member

Hi @ncaq, Could you please take a look at the failing checks?

@ncaq
Copy link
Author

ncaq commented Aug 31, 2023

@sgowroji
As I already commented, it succeeds with Bazel v7, but fails with Bazel v6.

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Aug 31, 2023
@meteorcloudy
Copy link
Member

meteorcloudy commented Sep 5, 2023

We are in the process of migrating to Bzlmod, can you submit the new version to the BCR?

Context: #18957

@meteorcloudy meteorcloudy added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 5, 2023
@strophy
Copy link

strophy commented Jun 9, 2024

Looks like this has been superseded by #22246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-response Awaiting a response from the author team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants