Update unknown Xcode version error message and provide an environment variable to force re-evaluation #19512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variable to force re-evaluation As of c747ae7, you need to run `bazel sync --configure` instead of `bazel shutdown`, to force re-finding of Xcode versions. Certain setups have a hard time running that new command, versus previously only having to cause Bazel to restart. To accommodate that, I’ve also added the `XCODE_VERSION` variable to `environ` (to match a similar use defined here: bazelbuild/apple_support@ddf25c2), which allows those setups to force the re-evaluation by using `--repo_env`. Signed-off-by: Brentley Jones <github@brentleyjones.com>
github-actions
bot
added
the
awaiting-review
keith
approved these changes
Sep 13, 2023
|
@brentleyjones Could you elaborate on what challenges are linked to running (The PR is totally fine, I just want to understand this better.) |
|
In rules_xcodeproj we have nested Bazel invocations and output bases. Users don't run commands on the nested output bases, so if they run |
brentleyjones
commented
Sep 13, 2023
Signed-off-by: Brentley Jones <github@brentleyjones.com>
googlewalt
approved these changes
Sep 14, 2023
brentleyjones
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io flag |
brentleyjones
deleted the
bj/update-unknown-xcode-version-error-message-and-provide-an-environment-variable-to-force-re-evaluation
branch
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.4.0 |
bazel-io
removed
the
potential release blocker
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 15, 2023
… variable to force re-evaluation As of c747ae7, you need to run `bazel sync --configure` instead of `bazel shutdown`, to force re-finding of Xcode versions. Certain setups have a hard time running that new command, versus previously only having to cause Bazel to restart. To accommodate that, I’ve also added the `XCODE_VERSION` variable to `environ` (to match a similar use defined here: bazelbuild/apple_support@ddf25c2), which allows those setups to force the re-evaluation by using `--repo_env`. And since the `default` attribute is influenced by `DEVELOPER_DIR`, I've included that in `environ` as well. Closes bazelbuild#19512. PiperOrigin-RevId: 565610471 Change-Id: Ideca7165308ce53fdf1ce22b31eeb7a9e681dedc
iancha1992
pushed a commit
that referenced
this pull request
Sep 15, 2023
…ironment variable to force re-evaluation (#19540) As of c747ae7, you need to run `bazel sync --configure` instead of `bazel shutdown`, to force re-finding of Xcode versions. Certain setups have a hard time running that new command, versus previously only having to cause Bazel to restart. To accommodate that, I’ve also added the `XCODE_VERSION` variable to `environ` (to match a similar use defined here: bazelbuild/apple_support@ddf25c2), which allows those setups to force the re-evaluation by using `--repo_env`. And since the `default` attribute is influenced by `DEVELOPER_DIR`, I've included that in `environ` as well. Closes #19512. Commit 19979e6 PiperOrigin-RevId: 565610471 Change-Id: Ideca7165308ce53fdf1ce22b31eeb7a9e681dedc Co-authored-by: Brentley Jones <github@brentleyjones.com>
|
The changes in this PR have been included in Bazel 6.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of c747ae7, you need to run
bazel sync --configureinstead ofbazel shutdown, to force re-finding of Xcode versions.Certain setups have a hard time running that new command, versus previously only having to cause Bazel to restart. To accommodate that, I’ve also added the
XCODE_VERSIONvariable toenviron(to match a similar use defined here: bazelbuild/apple_support@ddf25c2), which allows those setups to force the re-evaluation by using--repo_env. And since thedefaultattribute is influenced byDEVELOPER_DIR, I've included that inenvironas well.