Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.4.0] Error on potential unsupported /showIncludes lines #19611

Merged
merged 3 commits into from
Sep 25, 2023
Merged

[6.4.0] Error on potential unsupported /showIncludes lines #19611

merged 3 commits into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. Error on potential unsupported /showIncludes lines 

    This error ensures that removing the English language pack for MSVC
without also refetching `@local_config_cc` doesn't result in silently
incorrect incremental builds.

I considered making this a warning instead, but that would either result
in warning spam (if a false positive) or drown in the unfiltered MSVC
output (if a true positive). Making this an error is better for
correctness and will lead users to report any false positive matches.

Fixes bazelbuild#19439 (comment)

Closes bazelbuild#19580.

PiperOrigin-RevId: 568133958
Change-Id: If43924da6ba2f332edf4db0aed24056aa89fbb75
    @fmeum @bazel-io
    fmeum authored and bazel-io committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    a29f4fc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-6.4.0' into cp19580-6.4.0

    @meteorcloudy
    meteorcloudy authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d31ff7b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'release-6.4.0' into cp19580-6.4.0

    @iancha1992
    iancha1992 authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    d652e9e View commit details
    Browse the repository at this point in the history