Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support C++20 Modules #19940

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ public enum ArtifactCategory {
OBJECT_FILE("", ".o", ".obj"),
PIC_OBJECT_FILE("", ".pic.o"),
CPP_MODULE("", ".pcm"),
CPP20_MODULES_INFO("", ".CXXModules.json"),
CPP20_MODULE_DEP("", ".ddi"),
CPP20_MODULE_MAP("", ".modmap"),
CPP20_MODULE_MAP_INPUT("", ".modmap.input"),
GENERATED_ASSEMBLY("", ".s", ".asm"),
PROCESSED_HEADER("", ".processed"),
GENERATED_HEADER("", ".h"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ java_library(
"//third_party:caffeine",
"//third_party:checker_framework_annotations",
"//third_party:flogger",
"//third_party:gson",
"//third_party:guava",
"//third_party:jsr305",
"//third_party/protobuf:protobuf_java",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ public final class CcCommon implements StarlarkValue {
CppActionNames.CPP_HEADER_PARSING,
CppActionNames.CPP_MODULE_COMPILE,
CppActionNames.CPP_MODULE_CODEGEN,
CppActionNames.CPP20_DEPS_SCANNING,
CppActionNames.CPP20_MODULE_COMPILE,
CppActionNames.CPP20_MODULE_CODEGEN,
CppActionNames.ASSEMBLE,
CppActionNames.PREPROCESS_ASSEMBLE,
CppActionNames.CLIF_MATCH,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ public final class CcCompilationContext implements CcCompilationContextApi<Artif
private final NestedSet<Artifact> transitiveModules;
private final NestedSet<Artifact> transitivePicModules;

private final NestedSet<Artifact.DerivedArtifact> pcmFiles;
private final NestedSet<Artifact.DerivedArtifact> picPcmFiles;
private final NestedSet<Artifact> modulesInfoFiles;
private final NestedSet<Artifact> picModulesInfoFiles;

private final CppModuleMap cppModuleMap;

private final boolean propagateModuleMapAsActionInput;
Expand Down Expand Up @@ -111,6 +116,10 @@ private CcCompilationContext(
HeaderInfo headerInfo,
NestedSet<Artifact> transitiveModules,
NestedSet<Artifact> transitivePicModules,
NestedSet<Artifact.DerivedArtifact> pcmFiles,
NestedSet<Artifact.DerivedArtifact> picPcmFiles,
NestedSet<Artifact> modulesInfoFiles,
NestedSet<Artifact> picModulesInfoFiles,
ImmutableList<Artifact> directModuleMaps,
ImmutableList<CppModuleMap> exportingModuleMaps,
CppModuleMap cppModuleMap,
Expand All @@ -125,6 +134,10 @@ private CcCompilationContext(
this.headerInfo = headerInfo;
this.transitiveModules = transitiveModules;
this.transitivePicModules = transitivePicModules;
this.pcmFiles = pcmFiles;
this.picPcmFiles = picPcmFiles;
this.modulesInfoFiles = modulesInfoFiles;
this.picModulesInfoFiles = picModulesInfoFiles;
this.cppModuleMap = cppModuleMap;
this.nonCodeInputs = nonCodeInputs;
this.compilationPrerequisites = compilationPrerequisites;
Expand Down Expand Up @@ -550,6 +563,14 @@ public NestedSet<Artifact> getTransitiveModules(boolean usePic) {
return usePic ? transitivePicModules : transitiveModules;
}

public NestedSet<Artifact.DerivedArtifact> getPcmFiles(boolean usePic) {
return usePic ? picPcmFiles: pcmFiles;
}

public NestedSet<Artifact> getModulesInfoFiles(boolean usePic) {
return usePic ? picModulesInfoFiles : modulesInfoFiles;
}

@Override
public Depset getStarlarkTransitiveModules(boolean usePic, StarlarkThread thread)
throws EvalException {
Expand Down Expand Up @@ -627,6 +648,44 @@ ImmutableList<String> getNonTransitiveDefines() {
return commandLineCcCompilationContext.localDefines;
}

public static CcCompilationContext createWithCpp20Modules(
CcCompilationContext ccCompilationContext,
NestedSet<Artifact.DerivedArtifact> pcmFiles,
NestedSet<Artifact.DerivedArtifact> picPcmFiles,
ImmutableList<Artifact> modulesInfoFiles,
ImmutableList<Artifact> picModulesInfoFiles) {
var pcmFilesBuilder = NestedSetBuilder
.fromNestedSet(ccCompilationContext.pcmFiles)
.addTransitive(pcmFiles);
var picPcmFilesBuilder = NestedSetBuilder
.fromNestedSet(ccCompilationContext.picPcmFiles)
.addTransitive(picPcmFiles);
var modulesInfoFilesBuilder = NestedSetBuilder
.fromNestedSet(ccCompilationContext.modulesInfoFiles)
.addAll(modulesInfoFiles);
var picModulesInfoFilesBuilder = NestedSetBuilder
.fromNestedSet(ccCompilationContext.picModulesInfoFiles)
.addAll(picModulesInfoFiles);
return new CcCompilationContext(
ccCompilationContext.commandLineCcCompilationContext,
ccCompilationContext.compilationPrerequisites,
ccCompilationContext.declaredIncludeSrcs,
ccCompilationContext.nonCodeInputs,
ccCompilationContext.headerInfo,
ccCompilationContext.transitiveModules,
ccCompilationContext.transitivePicModules,
pcmFilesBuilder.build(),
picPcmFilesBuilder.build(),
modulesInfoFilesBuilder.build(),
picModulesInfoFilesBuilder.build(),
ccCompilationContext.directModuleMaps,
ccCompilationContext.exportingModuleMaps,
ccCompilationContext.cppModuleMap,
ccCompilationContext.propagateModuleMapAsActionInput,
ccCompilationContext.virtualToOriginalHeaders,
ccCompilationContext.headerTokens);
}

/**
* Returns a {@code CcCompilationContext} that is based on a given {@code CcCompilationContext},
* with {@code extraHeaderTokens} added to the header tokens.
Expand All @@ -644,6 +703,10 @@ public static CcCompilationContext createWithExtraHeaderTokens(
ccCompilationContext.headerInfo,
ccCompilationContext.transitiveModules,
ccCompilationContext.transitivePicModules,
ccCompilationContext.pcmFiles,
ccCompilationContext.picPcmFiles,
ccCompilationContext.modulesInfoFiles,
ccCompilationContext.picModulesInfoFiles,
ccCompilationContext.directModuleMaps,
ccCompilationContext.exportingModuleMaps,
ccCompilationContext.cppModuleMap,
Expand Down Expand Up @@ -765,6 +828,10 @@ private void mergeDependentCcCompilationContext(
TransitiveSetHelper<String> allDefines,
NestedSetBuilder<Artifact> transitiveModules,
NestedSetBuilder<Artifact> transitivePicModules,
NestedSetBuilder<Artifact.DerivedArtifact> pcmFiles,
NestedSetBuilder<Artifact.DerivedArtifact> picPcmFiles,
NestedSetBuilder<Artifact> modulesInfoFiles,
NestedSetBuilder<Artifact> picModulesInfoFiles,
Set<Artifact> directModuleMaps) {
Preconditions.checkNotNull(otherCcCompilationContext);
compilationPrerequisites.addTransitive(
Expand All @@ -785,6 +852,11 @@ private void mergeDependentCcCompilationContext(
addIfNotNull(transitivePicModules, otherCcCompilationContext.headerInfo.picHeaderModule);
addIfNotNull(transitivePicModules, otherCcCompilationContext.headerInfo.separatePicModule);

pcmFiles.addTransitive(otherCcCompilationContext.pcmFiles);
picPcmFiles.addTransitive(otherCcCompilationContext.picPcmFiles);
modulesInfoFiles.addTransitive(otherCcCompilationContext.modulesInfoFiles);
picModulesInfoFiles.addTransitive(otherCcCompilationContext.picModulesInfoFiles);

nonCodeInputs.addTransitive(otherCcCompilationContext.nonCodeInputs);

// All module maps of direct dependencies are inputs to the current compile independently of
Expand Down Expand Up @@ -842,6 +914,10 @@ private void mergeDependentCcCompilationContexts(
TransitiveSetHelper<String> allDefines,
NestedSetBuilder<Artifact> transitiveModules,
NestedSetBuilder<Artifact> transitivePicModules,
NestedSetBuilder<Artifact.DerivedArtifact> pcmFiles,
NestedSetBuilder<Artifact.DerivedArtifact> picPcmFiles,
NestedSetBuilder<Artifact> modulesInfoFiles,
NestedSetBuilder<Artifact> picModulesInfoFiles,
Set<Artifact> directModuleMaps,
Set<CppModuleMap> exportingModuleMaps) {
for (CcCompilationContext ccCompilationContext :
Expand All @@ -851,6 +927,10 @@ private void mergeDependentCcCompilationContexts(
allDefines,
transitiveModules,
transitivePicModules,
pcmFiles,
picPcmFiles,
modulesInfoFiles,
picModulesInfoFiles,
directModuleMaps);
}

Expand Down Expand Up @@ -1079,6 +1159,10 @@ public CcCompilationContext build() {
TransitiveSetHelper<String> allDefines = new TransitiveSetHelper<>();
NestedSetBuilder<Artifact> transitiveModules = NestedSetBuilder.stableOrder();
NestedSetBuilder<Artifact> transitivePicModules = NestedSetBuilder.stableOrder();
NestedSetBuilder<Artifact.DerivedArtifact> pcmFiles = NestedSetBuilder.stableOrder();
NestedSetBuilder<Artifact.DerivedArtifact> picPcmFiles = NestedSetBuilder.stableOrder();
NestedSetBuilder<Artifact> modulesInfoFiles = NestedSetBuilder.stableOrder();
NestedSetBuilder<Artifact> picModulesInfoFiles = NestedSetBuilder.stableOrder();
Set<Artifact> directModuleMaps = new LinkedHashSet<>();
Set<CppModuleMap> exportingModuleMaps = new LinkedHashSet<>();
mergeDependentCcCompilationContexts(
Expand All @@ -1087,6 +1171,10 @@ public CcCompilationContext build() {
allDefines,
transitiveModules,
transitivePicModules,
pcmFiles,
picPcmFiles,
modulesInfoFiles,
picModulesInfoFiles,
directModuleMaps,
exportingModuleMaps);

Expand All @@ -1110,6 +1198,10 @@ public CcCompilationContext build() {
headerInfo,
transitiveModules.build(),
transitivePicModules.build(),
pcmFiles.build(),
picPcmFiles.build(),
modulesInfoFiles.build(),
picModulesInfoFiles.build(),
ImmutableList.copyOf(directModuleMaps),
ImmutableList.copyOf(exportingModuleMaps),
cppModuleMap,
Expand Down
Loading