Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print an error message when the downloader configuration file is missing. #20061

Closed
wants to merge 1 commit into from
Closed

Print an error message when the downloader configuration file is missing. #20061

wants to merge 1 commit into from

Conversation

tjgq
Copy link
Contributor

@tjgq tjgq commented Nov 6, 2023 •
edited
Loading

Fixes #20058.

@tjgq tjgq changed the title Print an error message when the downloader configuration file is miss… Print an error message when the downloader configuration file is misssing. Nov 6, 2023
@tjgq tjgq changed the title Print an error message when the downloader configuration file is misssing. Print an error message when the downloader configuration file is missing. Nov 6, 2023
@tjgq tjgq marked this pull request as ready for review November 6, 2023 13:57
@tjgq tjgq requested a review from coeuvre November 6, 2023 13:57
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Nov 6, 2023
@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 6, 2023
@tjgq
Copy link
Contributor Author

tjgq commented Nov 6, 2023

@bazel-io fork 7.0.0

@bazel-io bazel-io mentioned this pull request Nov 6, 2023
Closed
@copybara-service copybara-service bot closed this in 371e927 Nov 8, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 8, 2023
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Nov 8, 2023
@tjgq @bazel-io
Print an error message when the downloader configuration file is miss…
96ddba9 
…ing.

Fixes bazelbuild#20058.

Closes bazelbuild#20061.

PiperOrigin-RevId: 580442451
Change-Id: Ic0a856e843428d655b6d11d437af7be76f3cc573
@bazel-io bazel-io mentioned this pull request Nov 8, 2023
Merged
keertk pushed a commit that referenced this pull request Nov 8, 2023
@bazel-io @tjgq
[7.0.0] Print an error message when the downloader configuration file…
cb91b9e 
… is missing. (#20092)

Fixes #20058.

Closes #20061.

Commit
371e927

PiperOrigin-RevId: 580442451
Change-Id: Ic0a856e843428d655b6d11d437af7be76f3cc573

Co-authored-by: Tiago Quelhas <tjgq@google.com>
@tjgq tjgq deleted the downloader-not-found branch March 7, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel fails silently when the experimental_downloader_config path does not exist
2 participants
@tjgq @coeuvre