Intern module extension repo mapping entries via a SkyFunction
#20095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 74aadb2, the entries of `RepositoryMapping`s are interned to prevent quadratic memory usage for module extensions that create many repos. By using a dedicated `SkyFunction` instead of an interner, the CPU time spent on computing the identical repository mappings for extension repos, which showed up in profiles, is saved in addition to the memory usage.
fmeum
requested review from
aiuto
and removed request for
a team,
meteorcloudy and
aiuto
github-actions
bot
added
awaiting-review
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 7.0.0 |
bazel-io
removed
the
potential release blocker
fmeum
removed
the
team-Configurability
Wyverald
reviewed
Nov 8, 2023
.../java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionRepoMappingEntriesValue.java
Outdated
Show resolved
Hide resolved
Wyverald
approved these changes
Nov 8, 2023
Wyverald
added
awaiting-PR-merge
|
Hi @fmeum, Could you please resolve the code conflicts? This PR is awaiting to merge. Thanks! |
|
@sgowroji I resolved it. |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 10, 2023
Since 74aadb2, the entries of `RepositoryMapping`s are interned to prevent quadratic memory usage for module extensions that create many repos. By using a dedicated `SkyFunction` instead of an interner, the CPU time spent on computing the identical repository mappings for extension repos, which showed up in profiles, is saved in addition to the memory usage. Closes bazelbuild#20095. PiperOrigin-RevId: 581177545 Change-Id: Ied5682ba90f5f771fedffbea1491e7b2f6c27145
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 10, 2023
…on` (#20137) Since 74aadb2, the entries of `RepositoryMapping`s are interned to prevent quadratic memory usage for module extensions that create many repos. By using a dedicated `SkyFunction` instead of an interner, the CPU time spent on computing the identical repository mappings for extension repos, which showed up in profiles, is saved in addition to the memory usage. Closes #20095. Commit 07a571f PiperOrigin-RevId: 581177545 Change-Id: Ied5682ba90f5f771fedffbea1491e7b2f6c27145 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
|
The changes in this PR have been included in Bazel 7.0.0 RC5. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 74aadb2, the entries of
RepositoryMappings are interned to prevent quadratic memory usage for module extensions that create many repos. By using a dedicatedSkyFunctioninstead of an interner, the CPU time spent on computing the identical repository mappings for extension repos, which showed up in profiles, is saved in addition to the memory usage.