Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce lockfile update #20101

Closed
wants to merge 9 commits into from

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Nov 8, 2023

After this change, please make sure to update the lockfile by running bazel mod deps whenever you change the MODULE.bazel file or any .bzl file used in it.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 8, 2023
@meteorcloudy meteorcloudy changed the title WIP: Enforce lockfile update Enforce lockfile update Nov 8, 2023
@copybara-service copybara-service bot closed this in a7b1d36 Nov 8, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 8, 2023
meteorcloudy added a commit to meteorcloudy/bazel that referenced this pull request Nov 9, 2023
- Upgraded rules_python to 0.26.0 to include bazelbuild/rules_python#1433
- Updated the lockfile on all supported platforms.
- Enable `--lockfile_mode=update` for regular builds (mostly affecting local build)
- Enable `--lockfile_mode=error` for CI builds to ensure lockfile is up-to-date.

After this change, please make sure to update the lockfile by running `bazel mod deps` whenever you change the MODULE.bazel file or any .bzl file used in it.

Closes bazelbuild#20101.

PiperOrigin-RevId: 580553351
Change-Id: I54c3298e6c23c8392226e1e32ba203689f334226
meteorcloudy added a commit that referenced this pull request Nov 9, 2023
- Upgraded rules_python to 0.26.0 to include
bazelbuild/rules_python#1433
- Updated the lockfile on all supported platforms.
- Enable `--lockfile_mode=update` for regular builds (mostly affecting
local build)
- Enable `--lockfile_mode=error` for CI builds to ensure lockfile is
up-to-date.

After this change, please make sure to update the lockfile by running
`bazel mod deps` whenever you change the MODULE.bazel file or any .bzl
file used in it.

Closes #20101.

PiperOrigin-RevId: 580553351
Change-Id: I54c3298e6c23c8392226e1e32ba203689f334226
meteorcloudy added a commit to bazelbuild/continuous-integration that referenced this pull request Nov 9, 2023
- Set `--lockfile_mode=off` for downstream pipelines so that
bazelbuild/bazel#20101 won't break Bazel in
downstream pipeline.
- Support filterting out build and test targets by `no_bazel_downstream`
tag in downstream pipelines, addressing
bazelbuild/rules_python#1481 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant