Don't send unnecessary lockfile event #20154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BazelLockFileModule` is the only consumer of `BazelModuleResolutionEvent` and only subscribes with `--lockfile_mode=update`.
fmeum
changed the title
fmeum
requested review from
SalmaSamy and
Wyverald
and removed request for
Wyverald and
meteorcloudy
|
@bazel-io flag |
github-actions
bot
added
awaiting-review
bazel-io
added
the
potential release blocker
|
@bazel-io fork 7.0.0 |
bazel-io
removed
the
potential release blocker
SalmaSamy
approved these changes
Nov 13, 2023
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 13, 2023
`BazelLockFileModule` is the only consumer of `BazelModuleResolutionEvent` and only subscribes with `--lockfile_mode=update`. Closes bazelbuild#20154. PiperOrigin-RevId: 581955314 Change-Id: I2ef8a39833c1d195eccdd32fd8e3f86782979dc5
|
The changes in this PR have been included in Bazel 7.0.0 RC5. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BazelLockFileModuleis the only consumer ofBazelModuleResolutionEventand only subscribes with--lockfile_mode=update.