Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit actual hash in same format as expected hash #20155

Closed
wants to merge 9 commits into from
Closed

Emit actual hash in same format as expected hash #20155

wants to merge 9 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 12, 2023

Work towards #17803

@fmeum fmeum changed the title Emit actual hashes in same format as expected Emit actual hash in same format as expected hash Nov 12, 2023
@fmeum fmeum force-pushed the actual-hash branch 2 times, most recently from c95fbdc to b16d341 Compare November 12, 2023 11:28
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 13, 2023

This really wants to be a sealed class, but we don't have those yet.

@fmeum fmeum marked this pull request as ready for review November 13, 2023 11:11
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Nov 13, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 13, 2023 •
edited
Loading

@meteorcloudy I currently don't have access to a device on which I could reset the lockfile, could you do that (e.g. on import)?

@meteorcloudy
Copy link
Member

Of course, np!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 13, 2023
@meteorcloudy
Copy link
Member

I'm importing this one myself.

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 13, 2023

Pushed an update to hopefully fix the failing test

@fmeum
Copy link
Collaborator Author

fmeum commented Nov 13, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 13, 2023
@meteorcloudy
Copy link
Member

@bazel-io fork 7.0.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 13, 2023
@bazel-io bazel-io mentioned this pull request Nov 13, 2023
Closed
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 14, 2023
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Nov 14, 2023
@fmeum @bazel-io
Emit actual hash in same format as expected hash
2a72bf8 
Work towards bazelbuild#17803

Closes bazelbuild#20155.

PiperOrigin-RevId: 582237355
Change-Id: I65dfabe0b3a7a87c5d85a9d0383d3831bbb56590
@bazel-io bazel-io mentioned this pull request Nov 14, 2023
Merged
meteorcloudy pushed a commit that referenced this pull request Nov 14, 2023
@bazel-io @fmeum
[7.0.0] Emit actual hash in same format as expected hash (#20189)
191824c 
Work towards #17803

Closes #20155.

Commit
651c185

PiperOrigin-RevId: 582237355
Change-Id: I65dfabe0b3a7a87c5d85a9d0383d3831bbb56590

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmeum @meteorcloudy @bazel-io