-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove visionos_x86_64 CPUs #20335
Closed
Closed
Remove visionos_x86_64 CPUs #20335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple has since changed visionOS to only support arm macs
keith
force-pushed
the
ks/remove-visionos_x86_64-cpus
branch
from
November 27, 2023 17:55
4210536
to
cce03ef
Compare
brentleyjones
approved these changes
Nov 27, 2023
github-actions
bot
added
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Jan 22, 2024
lberki
approved these changes
Jan 23, 2024
lberki
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Jan 23, 2024
github-actions
bot
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Jan 24, 2024
@bazel-io flag |
bazel-io
added
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Jan 24, 2024
@bazel-io fork 7.1.0 |
bazel-io
removed
the
potential release blocker
Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone
label
Jan 24, 2024
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 24, 2024
Apple has since changed visionOS to only support arm macs Closes bazelbuild#20335. PiperOrigin-RevId: 601022333 Change-Id: I6322c68102129eb230bbbb4546249cb22899fe94
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Feb 7, 2024
This is a follow-up to bazelbuild#20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have). Closes bazelbuild#21150. PiperOrigin-RevId: 604910241 Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
This is a follow-up to #20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have). Closes #21150. Commit 6922aea PiperOrigin-RevId: 604910241 Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930 Co-authored-by: Patrick Balestra <me@patrickbalestra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple has since changed visionOS to only support arm macs