Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visionos_x86_64 CPUs #20335

Closed

Conversation

keith
Copy link
Member

@keith keith commented Nov 27, 2023

Apple has since changed visionOS to only support arm macs

Apple has since changed visionOS to only support arm macs
@keith keith force-pushed the ks/remove-visionos_x86_64-cpus branch from 4210536 to cce03ef Compare November 27, 2023 17:55
@keith keith marked this pull request as ready for review January 22, 2024 20:00
@keith keith requested a review from lberki as a code owner January 22, 2024 20:00
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 22, 2024
@lberki lberki added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 23, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 24, 2024
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 24, 2024
@iancha1992
Copy link
Member

@bazel-io fork 7.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 24, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 24, 2024
Apple has since changed visionOS to only support arm macs

Closes bazelbuild#20335.

PiperOrigin-RevId: 601022333
Change-Id: I6322c68102129eb230bbbb4546249cb22899fe94
github-merge-queue bot pushed a commit that referenced this pull request Jan 29, 2024
Apple has since changed visionOS to only support arm macs

Closes #20335.

Commit
ce9fa8e

PiperOrigin-RevId: 601022333
Change-Id: I6322c68102129eb230bbbb4546249cb22899fe94

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
copybara-service bot pushed a commit that referenced this pull request Feb 7, 2024
This is a follow-up to #20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have).

Closes #21150.

PiperOrigin-RevId: 604910241
Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 7, 2024
This is a follow-up to bazelbuild#20335. Given the fact that x86_64 isn't supported for visionOS, we should change the default to be sim_arm64 (the simulator version to follow the other CPU defaults we have).

Closes bazelbuild#21150.

PiperOrigin-RevId: 604910241
Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930
github-merge-queue bot pushed a commit that referenced this pull request Feb 7, 2024
This is a follow-up to #20335.
Given the fact that x86_64 isn't supported for visionOS, we should
change the default to be sim_arm64 (the simulator version to follow the
other CPU defaults we have).

Closes #21150.

Commit
6922aea

PiperOrigin-RevId: 604910241
Change-Id: I1f60fd9ee61e74597a667d5e175887e78e668930

Co-authored-by: Patrick Balestra <me@patrickbalestra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants