Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re enable android tests #20348

Closed
wants to merge 2 commits into from
Closed

Conversation

katre
Copy link
Member

@katre katre commented Nov 28, 2023

Work towards #18776.

Centos tests are still disabled because of python version issues: #18776 (comment)

These tests were disabled as part of bazelbuild#18776.
@katre katre force-pushed the re-enable-android-tests branch from 1198d98 to e8ce610 Compare November 29, 2023 15:56
@katre katre changed the title [WIP] Re enable android tests Re enable android tests Nov 29, 2023
@meteorcloudy
Copy link
Member

meteorcloudy commented Nov 29, 2023

I canceled and retriggered the centos builds to fetch the new image.

@katre
Copy link
Member Author

katre commented Nov 29, 2023

Let me cancel and re-enable those tests :)

@katre katre force-pushed the re-enable-android-tests branch from e8ce610 to ce7c891 Compare November 29, 2023 16:02
@katre katre marked this pull request as ready for review November 29, 2023 16:03
@katre
Copy link
Member Author

katre commented Nov 29, 2023

Looks like it's still using python 2.7.

I'm going to re-push the version that enables everything else, and look into centos more later.

@meteorcloudy
Copy link
Member

I checked the image the job pulled is correct and do have python as python 3. Can you try to reproduce locally with the new image?

@katre
Copy link
Member Author

katre commented Nov 29, 2023

Need to re-open bazelbuild/continuous-integration#1823 as I messed it up

@iancha1992 iancha1992 added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website team-Android Issues for Android team awaiting-review PR is awaiting review from an assigned reviewer and removed team-Android Issues for Android team labels Nov 29, 2023
@copybara-service copybara-service bot closed this in 5232ab2 Dec 4, 2023
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 4, 2023
@katre katre deleted the re-enable-android-tests branch December 4, 2023 13:28
Wyverald pushed a commit that referenced this pull request Jan 3, 2024
Work towards #18776.

Centos tests are still disabled because of python version issues: #18776 (comment)

Closes #20348.

PiperOrigin-RevId: 587674122
Change-Id: Id99b09d9dc184f015f02e4ebc921dcfa58adcc45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants