Don't issue GetCapabilities calls if the requirement is NONE #20355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Remote-Exec
tjgq
reviewed
Nov 29, 2023
Comment on lines
+102
to
+106
| // Don't issue GetCapabilities calls if the requirement is NONE because the endpoint, | ||
| // e.g. Remote Asset API, might not implement the API. See #20342. | ||
| if (requirement == ServerCapabilitiesRequirement.NONE) { | ||
| return Single.just( | ||
| new ChannelConnectionWithServerCapabilities(channel, serverCapabilitiesSingle)); |
There was a problem hiding this comment.
Is the logic reversed? This to me reads as "if the requirement is NONE, then call getAndVerifyServerCapabilities".
There was a problem hiding this comment.
No. serverCapabilitiesSingle is a lazy evaluation of getAndVerifyServerCapabilities.
If the requirement is NONE, we store it and call getAndVerifyServerCapabilities only when ChannelConnectionWithServerCapabilities#getCapabilities is called.
Otherwise, we evaluate the single now which calls getAndVerifyServerCapabilities immediately.
tjgq
approved these changes
Nov 30, 2023
github-actions
bot
removed
the
awaiting-review
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 30, 2023
Because the endpoint might not implement the `GetCapabilities` API, e.g. Remote Asset API. Fixes bazelbuild#20342. Closes bazelbuild#20355. PiperOrigin-RevId: 586642258 Change-Id: If9ca3a1909729ea5d9410b7198bcacb5d67781aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the endpoint might not implement the
GetCapabilitiesAPI, e.g. Remote Asset API.Fixes #20342.