Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiling to remoteActionBuildingSemaphore.acquire() #20474

Conversation

brentleyjones
Copy link
Contributor

Without this there can be large gaps in the profile when using remote execution that are hard to reason about.

Without this there can be large gaps in the profile when using remote execution that are hard to reason about.

Signed-off-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones brentleyjones requested a review from a team as a code owner December 8, 2023 17:19
@github-actions github-actions bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Dec 8, 2023
Signed-off-by: Brentley Jones <github@brentleyjones.com>
@meisterT meisterT added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 12, 2023
@brentleyjones
Copy link
Contributor Author

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 12, 2023
@iancha1992
Copy link
Member

@bazel-io fork 7.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 12, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 13, 2023
@brentleyjones
Copy link
Contributor Author

@iancha1992 This can probably go into 6.5.0 as well.

@iancha1992
Copy link
Member

@bazel-io fork 6.5.0

bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Dec 14, 2023
Without this there can be large gaps in the profile when using remote execution that are hard to reason about.

Closes bazelbuild#20474.

PiperOrigin-RevId: 590475989
Change-Id: Ic6e042c36f85e8098a468c73c62bd45cc367423e
github-merge-queue bot pushed a commit that referenced this pull request Dec 15, 2023
…20549)

Without this there can be large gaps in the profile when using remote
execution that are hard to reason about.

Closes #20474.

Commit
75fffbf

PiperOrigin-RevId: 590475989
Change-Id: Ic6e042c36f85e8098a468c73c62bd45cc367423e

Co-authored-by: Brentley Jones <github@brentleyjones.com>
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Dec 21, 2023
Without this there can be large gaps in the profile when using remote execution that are hard to reason about.

Closes bazelbuild#20474.

PiperOrigin-RevId: 590475989
Change-Id: Ic6e042c36f85e8098a468c73c62bd45cc367423e
github-merge-queue bot pushed a commit that referenced this pull request Jan 11, 2024
…20645)

Without this there can be large gaps in the profile when using remote
execution that are hard to reason about.

Closes #20474.

Commit
75fffbf

PiperOrigin-RevId: 590475989
Change-Id: Ic6e042c36f85e8098a468c73c62bd45cc367423e

Co-authored-by: Brentley Jones <github@brentleyjones.com>
Co-authored-by: Yun Peng <pcloudy@google.com>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 6.5.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

@Wyverald Wyverald deleted the bj/add-profiling-to-remoteactionbuildingsemaphore.acquire branch February 16, 2024 03:50
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants