Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.5.0] Ignore read-only errors when updating the mtime of the install_base #20568

Merged
merged 2 commits into from
Jan 9, 2024

Commits on Dec 15, 2023

  1. Ignore read-only errors when updating the mtime of the install_base

    Currently if the `--install_base` path passed is not writable by the user invoking Bazel, the Bazel client crashes:
    ```console
    ❯ bazel --install_base=/some/read/only/path version
    FATAL: failed to set timestamp on '/some/read/only/path': (error: 30): Read-only file system
    ```
    
    This happens because the Bazel client (unconditionally) attempts to update the `mtime` of this path:
    https://github.com/bazelbuild/bazel/blob/a3c677dfea2de636a719d50345a5a97af96fae60/src/main/cpp/blaze.cc#L1010-L1021
    
    This commit updates the client to ignore such errors. See bazelbuild#20373 for context.
    
    Closes bazelbuild#20442.
    
    PiperOrigin-RevId: 591266054
    Change-Id: If53e7cad48cb62406f7883f72b413e4b5a0bb8e2
    rrbutani authored and bazel-io committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    f25140b View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Configuration menu
    Copy the full SHA
    533cf23 View commit details
    Browse the repository at this point in the history