DigestUtils: avoid throwing on invalid digest function name #20574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
team-Remote-Exec
tjgq
requested changes
Dec 17, 2023
src/main/java/com/google/devtools/build/lib/remote/util/DigestUtil.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/remote/util/DigestUtil.java
Outdated
Show resolved
Hide resolved
christianscott
commented
Dec 17, 2023
| @@ -43,12 +46,13 @@ public DigestUtil(XattrProvider xattrProvider, DigestHashFunction hashFn) { | |||
| this.digestFunction = getDigestFunctionFromHashFunction(hashFn); | |||
| } | |||
|
|
|||
| private static final ImmutableSet<String> DIGEST_FUNCTION_NAMES = | |||
| Arrays.stream(DigestFunction.Value.values()).map(v -> v.name()).collect(toImmutableSet()); | |||
There was a problem hiding this comment.
btw – I could not find a java style guide for the bazel source code, so I assume you use 4 space continuations based on other parts of the codebase
There was a problem hiding this comment.
What helped me for contributions: The style guide is https://google.github.io/styleguide/javaguide.html and you can use https://github.com/google/google-java-format and its IDE plugins for formatting.
There was a problem hiding this comment.
Oh of course it's the google Java style guide. Thanks @fmeum!
|
@tjgq can I assume those CI failures are flakes? |
sgowroji
added
awaiting-user-response
coeuvre
approved these changes
Dec 18, 2023
coeuvre
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 7.1.0 |
bazel-io
removed
the
potential release blocker
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 21, 2023
9% of samples in a profile of one of our builds were inside the `fillInStackTrace()` method. Collecting the valid names into a hashset avoids needing to construct errors every time an invalid digest function name is passed into this function. Tested with Bazel 6.4.0. Our codebase is not yet compatible with Bazel 7. I have not investigated why this function was receiving so many invalid names. Before:  After:  My understanding is that this will not speed up builds directly, but it will allow BEP events to be processed more quickly. Closes bazelbuild#20574. PiperOrigin-RevId: 592094151 Change-Id: Ie23241c9ec40e59ba2aac1fc83e4830340260f45
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
…20650) 9% of samples in a profile of one of our builds were inside the `fillInStackTrace()` method. Collecting the valid names into a hashset avoids needing to construct errors every time an invalid digest function name is passed into this function. Tested with Bazel 6.4.0. Our codebase is not yet compatible with Bazel 7. I have not investigated why this function was receiving so many invalid names. Before:  After:  My understanding is that this will not speed up builds directly, but it will allow BEP events to be processed more quickly. Closes #20574. Commit cb08d62 PiperOrigin-RevId: 592094151 Change-Id: Ie23241c9ec40e59ba2aac1fc83e4830340260f45 Co-authored-by: Christian Scott <christian.s@canva.com> Co-authored-by: Ian (Hee) Cha <heec@google.com> Co-authored-by: Yun Peng <pcloudy@google.com>
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9% of samples in a profile of one of our builds were inside the
fillInStackTrace()method. Collecting the valid names into a hashset avoids needing to construct errors every time an invalid digest function name is passed into this function.Tested with Bazel 6.4.0. Our codebase is not yet compatible with Bazel 7.
I have not investigated why this function was receiving so many invalid names.
Before:
After:
My understanding is that this will not speed up builds directly, but it will allow BEP events to be processed more quickly.