-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add # support for LabelValidator as discussed in #2006 #2059
Conversation
Can one of the admins verify this patch? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I'm a Googler so I don't need to sign CLA. |
over to @damienmg who apparently made the suggestion. Please note that, as the account is not registered with the google oranisation, |
Add # to LabelValidator allowed list for query target.
Add test case for #
CLAs look good, thanks! |
I updated my information and commits and seems cla check automatically passed. |
Oops sorry, I forgot to import it yesterday. Yes using your @google.com email for the author in the commit fix it (which you should do if you are employed by google). |
Great, thank you. Does it break anything? |
ping? |
Sorry I sent the change to @lberki for review but he seemed to have missed On Thu, Nov 17, 2016 at 5:50 PM Meng Zhang notifications@github.com wrote:
|
Let's see what happens. We generally prefer patches through Gerrit, but it's a tiny simple one so I can just patch it in manually and run it through our internal test battery. |
As suggested by @damienmg in #2006 send this out to run it with internal test. Closes #2059 . Progress towards #374. -- Reviewed-on: bazelbuild/bazel#2059 MOS_MIGRATED_REVID=139562084
As suggested by @damienmg in #2006 send this out to run it with internal test.