Improve use_repo_rule error when not referencing a repository_rule
#20657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
fmeum
force-pushed
the
use-repo-rule-type
branch
from
e9b555a to
5c7a45d
Compare
sgowroji
added
awaiting-user-response
Makes the error message less confusing when referencing an existing symbol that happens to be a macro, not a repository rule.
fmeum
force-pushed
the
use-repo-rule-type
branch
from
5c7a45d to
a13ba3d
Compare
|
@bazel-io fork 7.1.0 |
meteorcloudy
approved these changes
Jan 2, 2024
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 3, 2024
Makes the error message less confusing when referencing an existing symbol that happens to be a macro, not a repository rule. Closes bazelbuild#20657. PiperOrigin-RevId: 595434847 Change-Id: Ifc37a65685c0196301d79a439f3245037cf39e21
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
…ory_rule` (#20732) Makes the error message less confusing when referencing an existing symbol that happens to be a macro, not a repository rule. Closes #20657. Commit 69fa6cb PiperOrigin-RevId: 595434847 Change-Id: Ifc37a65685c0196301d79a439f3245037cf39e21 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the error message less confusing when referencing an existing symbol that happens to be a macro, not a repository rule.