Add bazel mod dump_repo_mapping
#20686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
20631-dump-repo-mappings
branch
6 times, most recently
from
4bd8108 to
1bc5bee
Compare
fmeum
changed the title
bazel mod dump_repo_mapping and bash completion for external reposbazel mod dump_repo_mapping
fmeum
force-pushed
the
20631-dump-repo-mappings
branch
from
1bc5bee to
6cfd8e5
Compare
github-actions
bot
added
team-ExternalDeps
fmeum
force-pushed
the
20631-dump-repo-mappings
branch
from
6cfd8e5 to
3336ddf
Compare
|
Just tested integrating this into the Facebook starlark LSP and it seems to work as expected. |
Wyverald
reviewed
Jan 17, 2024
src/main/java/com/google/devtools/build/lib/skyframe/RepositoryMappingFunction.java
Outdated
Show resolved
Hide resolved
cameron-martin
added a commit
to cameron-martin/bazel-lsp
that referenced
this pull request
Jan 18, 2024
This uses the `bazel mod dump_repo_mapping` command (bazelbuild/bazel#20686) to map repositories to their canonical form when doing go to definition and autocomplete.
fmeum
force-pushed
the
20631-dump-repo-mappings
branch
from
3336ddf to
42714a4
Compare
Wyverald
reviewed
Jan 18, 2024
src/main/java/com/google/devtools/build/lib/skyframe/RepositoryMappingFunction.java
Outdated
Show resolved
Hide resolved
Wyverald
reviewed
Jan 18, 2024
`bazel mod dump_repo_mapping` with no arguments is explicitly made an error so that a new mode that dumps all repository mappings with a single Bazel invocation can be added later if needed, e.g. to support IntelliJ's "sync" workflow. RELNOTES: `bazel mod dump_repo_mapping <canonical repo name>...` returns the repository mappings of the given repositories in NDJSON. This information can be used by IDEs and Starlark language servers to resolve labels with `--enable_bzlmod`.
fmeum
force-pushed
the
20631-dump-repo-mappings
branch
from
42714a4 to
c749bfb
Compare
Wyverald
approved these changes
Jan 18, 2024
Wyverald
removed
the
awaiting-review
Wyverald
added
the
awaiting-PR-merge
|
@bazel-io fork 7.1.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 25, 2024
`bazel mod dump_repo_mapping` with no arguments is explicitly made an error so that a new mode that dumps all repository mappings with a single Bazel invocation can be added later if needed, e.g. to support IntelliJ's "sync" workflow. RELNOTES: `bazel mod dump_repo_mapping <canonical repo name>...` returns the repository mappings of the given repositories in NDJSON. This information can be used by IDEs and Starlark language servers to resolve labels with `--enable_bzlmod`. Work towards bazelbuild#20631 Closes bazelbuild#20686. PiperOrigin-RevId: 601332180 Change-Id: I828d7c88637bea175e11eccc52c6202f6da4c32c
iancha1992
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 26, 2024
`bazel mod dump_repo_mapping` with no arguments is explicitly made an error so that a new mode that dumps all repository mappings with a single Bazel invocation can be added later if needed, e.g. to support IntelliJ's "sync" workflow. RELNOTES: `bazel mod dump_repo_mapping <canonical repo name>...` returns the repository mappings of the given repositories in NDJSON. This information can be used by IDEs and Starlark language servers to resolve labels with `--enable_bzlmod`. Work towards bazelbuild#20631 Closes bazelbuild#20686. PiperOrigin-RevId: 601332180 Change-Id: I828d7c88637bea175e11eccc52c6202f6da4c32c
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
`bazel mod dump_repo_mapping` with no arguments is explicitly made an error so that a new mode that dumps all repository mappings with a single Bazel invocation can be added later if needed, e.g. to support IntelliJ's "sync" workflow. RELNOTES: `bazel mod dump_repo_mapping <canonical repo name>...` returns the repository mappings of the given repositories in NDJSON. This information can be used by IDEs and Starlark language servers to resolve labels with `--enable_bzlmod`. Work towards #20631 Closes #20686. Commit 59ac9ce PiperOrigin-RevId: 601332180 Change-Id: I828d7c88637bea175e11eccc52c6202f6da4c32c Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
cameron-martin
added a commit
to cameron-martin/bazel-lsp
that referenced
this pull request
Feb 22, 2024
This uses the `bazel mod dump_repo_mapping` command (bazelbuild/bazel#20686) to map repositories to their canonical form when doing go to definition and autocomplete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bazel mod dump_repo_mappingwith no arguments is explicitly made anerror so that a new mode that dumps all repository mappings with a
single Bazel invocation can be added later if needed, e.g. to support
IntelliJ's "sync" workflow.
RELNOTES:
bazel mod dump_repo_mapping <canonical repo name>...returnsthe repository mappings of the given repositories in NDJSON. This
information can be used by IDEs and Starlark language servers to resolve
labels with
--enable_bzlmod.Work towards #20631