Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1.0] Add profiles to the call sites of updateRunfiles #20803

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[7.1.0] Add profiles to the call sites of updateRunfiles #20803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/com/google/devtools/build/lib/exec/local/LocalSpawnRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,10 @@ public SpawnResult exec(Spawn spawn, SpawnExecutionContext context)
SpawnMetrics.Builder spawnMetrics = SpawnMetrics.Builder.forLocalExec();
Stopwatch totalTimeStopwatch = Stopwatch.createStarted();
Stopwatch setupTimeStopwatch = Stopwatch.createStarted();
runfilesTreeUpdater.updateRunfiles(
spawn.getRunfilesSupplier(), spawn.getEnvironment(), context.getFileOutErr());
try (var s = Profiler.instance().profile("updateRunfiles")) {
runfilesTreeUpdater.updateRunfiles(
spawn.getRunfilesSupplier(), spawn.getEnvironment(), context.getFileOutErr());
}
if (Spawns.shouldPrefetchInputsForLocalExecution(spawn)) {
context.prefetchInputsAndWait();
}
Expand Down
6 changes: 4 additions & 2 deletions src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,10 @@ public SpawnResult exec(Spawn spawn, SpawnExecutionContext context)
String.format(
"%s worker %s", spawn.getMnemonic(), spawn.getResourceOwner().describe()))) {

runfilesTreeUpdater.updateRunfiles(
spawn.getRunfilesSupplier(), spawn.getEnvironment(), context.getFileOutErr());
try (var s = Profiler.instance().profile("updateRunfiles")) {
runfilesTreeUpdater.updateRunfiles(
spawn.getRunfilesSupplier(), spawn.getEnvironment(), context.getFileOutErr());
}

InputMetadataProvider inputFileCache = context.getInputMetadataProvider();

Expand Down
Loading