Distinguish the disk and remote caches in the action progress status. #20935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgq
force-pushed
the
cache-name
branch
2 times, most recently
from
cbc5f49 to
2388856
Compare
tjgq
changed the title
coeuvre
reviewed
Jan 19, 2024
| @@ -49,6 +49,11 @@ public DiskAndRemoteCacheClient(DiskCacheClient diskCache, RemoteCacheClient rem | |||
| this.remoteCache = Preconditions.checkNotNull(remoteCache); | |||
| } | |||
|
|
|||
| @Override | |||
| public String getDisplayName() { | |||
| return "combined-cache"; | |||
There was a problem hiding this comment.
For combined cache, I would like it to first report disk-cache and then remote-cache if missed disk cache. Maybe we should move the event emission into the cache client?
There was a problem hiding this comment.
PTAL. (The architecture isn't great, but I don't see any better options.)
github-actions
bot
added
team-Remote-Exec
tjgq
changed the title
coeuvre
approved these changes
Jan 22, 2024
coeuvre
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 7.1.0 |
bazel-io
removed
the
potential release blocker
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 26, 2024
Previously, they were both displayed as `remote-cache`; there's now a separate `disk-cache` form. If a combined cache is used, one or both forms will appear, depending on which caches were looked up. As a result, the progress status reporting is moved to the individual cache implementations. While this is kind of unfortunate from an architectural standpoint, it's likely the best we can do until we recast cache lookups as spawn strategies (see bazelbuild#19904). Closes bazelbuild#20935. PiperOrigin-RevId: 601748051 Change-Id: I03710219973c95d4fca999d931b3513f6d240d94
tjgq
added a commit
to tjgq/bazel
that referenced
this pull request
Jan 26, 2024
Previously, they were both displayed as `remote-cache`; there's now a separate `disk-cache` form. If a combined cache is used, one or both forms will appear, depending on which caches were looked up. As a result, the progress status reporting is moved to the individual cache implementations. While this is kind of unfortunate from an architectural standpoint, it's likely the best we can do until we recast cache lookups as spawn strategies (see bazelbuild#19904). Closes bazelbuild#20935. PiperOrigin-RevId: 601748051 Change-Id: I03710219973c95d4fca999d931b3513f6d240d94
tjgq
added a commit
to tjgq/bazel
that referenced
this pull request
Jan 26, 2024
… status. Previously, they were both displayed as `remote-cache`; there's now a separate `disk-cache` form. If a combined cache is used, one or both forms will appear, depending on which caches were looked up. As a result, the progress status reporting is moved to the individual cache implementations. While this is kind of unfortunate from an architectural standpoint, it's likely the best we can do until we recast cache lookups as spawn strategies (see bazelbuild#19904). Closes bazelbuild#20935. PiperOrigin-RevId: 601748051 Change-Id: I03710219973c95d4fca999d931b3513f6d240d94
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2024
… status. (#21084) Previously, they were both displayed as `remote-cache`; there's now a separate `disk-cache` form. If a combined cache is used, one or both forms will appear, depending on which caches were looked up. As a result, the progress status reporting is moved to the individual cache implementations. While this is kind of unfortunate from an architectural standpoint, it's likely the best we can do until we recast cache lookups as spawn strategies (see #19904). Closes #20935. PiperOrigin-RevId: 601748051 Change-Id: I03710219973c95d4fca999d931b3513f6d240d94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, they were both displayed as
remote-cache; there's now a separatedisk-cacheform. If a combined cache is used, one or both forms will appear, depending on which caches were looked up.As a result, the progress status reporting is moved to the individual cache implementations. While this is kind of unfortunate from an architectural standpoint, it's likely the best we can do until we recast cache lookups as spawn strategies (see #19904).