Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.1.0] Also path map transitive header jar paths with direct classpath optimization #21227

Merged
merged 1 commit into from
Feb 8, 2024

Commits on Feb 6, 2024

  1. Also path map transitive header jar paths with direct classpath optim…

    …ization
    
    `JavaHeaderCompileAction` can apply an optimization where it compiles the source files only against direct dependencies, making use of the fact that Turbine includes sufficient information about transitive dependencies into the direct header jars in a special directory.
    
    In order to ensure that downstream consumers of header compilation action can use its `.jdeps` file regardless of which of these actions actually uses path mapping, all such paths to transitive jars have to be unmapped.
    
    With this commit, actions can declare additional artifacts whose paths they want to apply path mapping to. By always passing all transitive jars into the path mapper, even when only the direct jars are inputs to the action, the transitive header jar paths can be unmapped and stripped path collisions between them correctly result in a noop `PathMapper` being used for the current action.
    
    Fixes bazelbuild#21091
    
    Closes bazelbuild#19872.
    
    PiperOrigin-RevId: 604772306
    Change-Id: I21d25785b2e909aace8554251f41b1012185138a
    fmeum authored and bazel-io committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7b50c73 View commit details
    Browse the repository at this point in the history