[7.2.0] Fix swallowed I/O exception in LcovPrinter #22057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calling code expects the exception, not a return boolean. Fixes bazelbuild#21982. Closes bazelbuild#21987. PiperOrigin-RevId: 626086576 Change-Id: I4abd7a253715c84c323e036dfbdb2fcb94a4825d
bazel-io
added
the
awaiting-review
c-mita
approved these changes
Apr 18, 2024
c-mita
added
awaiting-PR-merge
iancha1992
removed
the
awaiting-PR-merge
Merged
via the queue into
bazelbuild:release-7.2.0
with commit Apr 18, 2024
2da699f
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calling code expects the exception, not a return boolean.
Fixes #21982.
Closes #21987.
PiperOrigin-RevId: 626086576
Change-Id: I4abd7a253715c84c323e036dfbdb2fcb94a4825d
Commit f8277cf