Revert special handling of yanked module files #22083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
changed the title
github-actions
bot
added
team-ExternalDeps
fmeum
force-pushed
the
20369-yanked-versions-overhaul
branch
from
e118465
to
3ea2188
Compare
|
I don't know what's up with the RBE test, it does look like flakiness though. |
|
Probably due to the same reason here: Line 424 in 364cc11 |
|
I triggered a rerun, but if it's too flaky, we'll have to find a way to disable the test on RBE |
|
I have a change to prevent those python tests from accessing BCR: #22089 |
fmeum
force-pushed
the
20369-yanked-versions-overhaul
branch
from
3ea2188
to
6f33204
Compare
|
@meteorcloudy Thanks, the issue is gone! |
Wyverald
approved these changes
Apr 23, 2024
Wyverald
added
awaiting-PR-merge
|
@bazel-io fork 7.2.0 |
sgowroji
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
May 6, 2024
This effectively reverts most of 2a2a474: Module files of yanked versions are evaluated just like those of any other versions and "yankedness" is only checked for the final dep graph after selection. This greatly simplifies incremental fetching of (inherently mutable) yanked version information with the new lockfile format. Work towards bazelbuild#20369 RELNOTES: `print` statements in module files are now only executed for the root module and modules subject to non-registry overrides (e.g. `local_path_override`). Closes bazelbuild#22083. PiperOrigin-RevId: 627953972 Change-Id: Ie0aba02d187e000450a89ad2cd281c173582880a
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 7, 2024
This effectively reverts most of 2a2a474: Module files of yanked versions are evaluated just like those of any other versions and "yankedness" is only checked for the final dep graph after selection. This greatly simplifies incremental fetching of (inherently mutable) yanked version information with the new lockfile format. Work towards #20369 RELNOTES: `print` statements in module files are now only executed for the root module and modules subject to non-registry overrides (e.g. `local_path_override`). Closes #22083. PiperOrigin-RevId: 627953972 Change-Id: Ie0aba02d187e000450a89ad2cd281c173582880a Commit 45982b4 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
This effectively reverts most of 2a2a474: Module files of yanked versions are evaluated just like those of any other versions and "yankedness" is only checked for the final dep graph after selection. This greatly simplifies incremental fetching of (inherently mutable) yanked version information with the new lockfile format. Work towards bazelbuild#20369 RELNOTES: `print` statements in module files are now only executed for the root module and modules subject to non-registry overrides (e.g. `local_path_override`). Closes bazelbuild#22083. PiperOrigin-RevId: 627953972 Change-Id: Ie0aba02d187e000450a89ad2cd281c173582880a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively reverts most of 2a2a474: Module files of yanked versions are evaluated just like those of any other versions and "yankedness" is only checked for the final dep graph after selection.
This greatly simplifies incremental fetching of (inherently mutable) yanked version information with the new lockfile format.
Work towards #20369
RELNOTES:
printstatements in module files are now only executed for the root module and modules subject to non-registry overrides (e.g.local_path_override).