Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2.0] Set public visibility for R8 desugar binary #22178

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

bazel-io
Copy link
Member

We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on
@bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android.

Part of bazelbuild/rules_android#122.

Closes #21775.

PiperOrigin-RevId: 618272641
Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1

Commit 32fd6e9

We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on
@bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android.

Part of bazelbuild/rules_android#122.

Closes bazelbuild#21775.

PiperOrigin-RevId: 618272641
Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1
@bazel-io bazel-io requested a review from a team as a code owner April 29, 2024 16:03
@bazel-io bazel-io added team-Android Issues for Android team awaiting-review PR is awaiting review from an assigned reviewer labels Apr 29, 2024
@bazel-io bazel-io requested a review from ahumesky April 29, 2024 16:03
@iancha1992 iancha1992 added this pull request to the merge queue Apr 29, 2024
Merged via the queue into bazelbuild:release-7.2.0 with commit 1ab19fe Apr 29, 2024
33 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Android Issues for Android team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants