-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow unconfigured alias
es during options parsing
#22192
Conversation
RELNOTES: Starlark command-line flags can now be referred to through `alias` targets.
@gregestren I picked this up since it is relevant for a design I'm working on: I want to build a general-purpose features system for Bazel modules, similar to that of Cargo. Modules can declare configurable features and have appropriate custom Starlark flags generated for them in a repository rule, with a managed default value. But this is only likely to work well if a module can wrap these generated flags in Hope that motivates this, happy to explain more about the context if you have concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java
Outdated
Show resolved
Hide resolved
@bazel-io fork 7.2.0 |
Fixes bazelbuild#20582 RELNOTES: Starlark command-line flags can now be referred to through `alias` targets. Closes bazelbuild#22192. PiperOrigin-RevId: 629865954 Change-Id: I6215c8484ddc08e75507191bfa1eb5bc709c5fc6
Fixes bazelbuild#20582 RELNOTES: Starlark command-line flags can now be referred to through `alias` targets. Closes bazelbuild#22192. PiperOrigin-RevId: 629865954 Change-Id: I6215c8484ddc08e75507191bfa1eb5bc709c5fc6
Fixes #20582
RELNOTES: Starlark command-line flags can now be referred to through
alias
targets.