Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format "Repository names and strict deps" bullet list #22663

Closed
wants to merge 1 commit into from

Conversation

dws
Copy link
Contributor

@dws dws commented Jun 7, 2024

The bullet list in the "Repository names and strict deps" section of https://bazel.build/external/module does not render properly on the website. However, other bullet lists on this page do render correctly. The difference is apparently the level of indentation. This PR attempts to correct the discrepancy.

The bullet list in the "Repository names and strict deps" section of https://bazel.build/external/module does not render properly on the website.  However, other bullet lists on this page do render correctly.  The difference is apparently the level of indentation.  This PR attempts to correct the discrepancy.
@dws dws marked this pull request as ready for review June 7, 2024 02:55
@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Jun 7, 2024
@sgowroji sgowroji added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Jun 7, 2024
@fmeum
Copy link
Collaborator

fmeum commented Jun 7, 2024

@meteorcloudy Could you review for approval?

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this and fixing it!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 7, 2024
@fmeum
Copy link
Collaborator

fmeum commented Jun 7, 2024

@bazel-io fork

@fmeum
Copy link
Collaborator

fmeum commented Jun 8, 2024

@bazel-io fork 7.3.0

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 10, 2024
@dws dws deleted the patch-1 branch June 10, 2024 16:05
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jun 10, 2024
The bullet list in the "Repository names and strict deps" section of https://bazel.build/external/module does not render properly on the website.  However, other bullet lists on this page do render correctly.  The difference is apparently the level of indentation.  This PR attempts to correct the discrepancy.

Closes bazelbuild#22663.

PiperOrigin-RevId: 641904379
Change-Id: I9d97841731ec99bad91796fff3fd3d62426b10ff
github-merge-queue bot pushed a commit that referenced this pull request Jun 10, 2024
The bullet list in the "Repository names and strict deps" section of
https://bazel.build/external/module does not render properly on the
website. However, other bullet lists on this page do render correctly.
The difference is apparently the level of indentation. This PR attempts
to correct the discrepancy.

Closes #22663.

PiperOrigin-RevId: 641904379
Change-Id: I9d97841731ec99bad91796fff3fd3d62426b10ff

Commit
f6687ad

Co-authored-by: David Sanderson <32687193+dws@users.noreply.github.com>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.3.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.3.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions team-Documentation Documentation improvements that cannot be directly linked to other team labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants