Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2.1] Replace //external:android/d8_jar_import with "@android_gmaven_r8//jar" #22699

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ted-xie
Copy link
Contributor

@ted-xie ted-xie commented Jun 11, 2024

When android sdk is defined, android_sdk_repository maps //external:android/d8_jar_import to androidsdk//:d8_jar_import, which refers to android_gmaven_r8//jar:jar.

PiperOrigin-RevId: 611144488
Change-Id: I4ee5945ce5a1fdb30e96775396ec3628cefaa2e8

When android sdk is defined, android_sdk_repository maps //external:android/d8_jar_import to androidsdk//:d8_jar_import, which refers to android_gmaven_r8//jar:jar.

PiperOrigin-RevId: 611144488
Change-Id: I4ee5945ce5a1fdb30e96775396ec3628cefaa2e8
@ted-xie ted-xie requested a review from a team as a code owner June 11, 2024 16:15
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Android Issues for Android team labels Jun 11, 2024
@ted-xie ted-xie changed the title Replace //external:android/d8_jar_import with "@android_gmaven_r8//jar" [7.2.1] Replace //external:android/d8_jar_import with "@android_gmaven_r8//jar" Jun 11, 2024
@keertk keertk enabled auto-merge June 11, 2024 16:55
@keertk keertk self-requested a review June 11, 2024 16:55
@keertk keertk added this to the 7.2.1 release blockers milestone Jun 11, 2024
@keertk
Copy link
Member

keertk commented Jun 11, 2024

@ted-xie could you send the same changes against release-7.3.0 as well please?

@keertk keertk added this pull request to the merge queue Jun 11, 2024
@ted-xie
Copy link
Contributor Author

ted-xie commented Jun 11, 2024

@keertk Done! #22705

Merged via the queue into bazelbuild:release-7.2.1 with commit 1419013 Jun 11, 2024
34 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Android Issues for Android team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants