Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat missing repo boundary files as transient errors #22700

Closed
wants to merge 1 commit into from
Closed

Treat missing repo boundary files as transient errors #22700

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 11, 2024

Fixes #22687

@fmeum
Copy link
Collaborator Author

fmeum commented Jun 11, 2024

@bazel-io fork 7.2.1

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jun 11, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 11, 2024

@bazel-io fork 7.3.0

This was referenced Jun 11, 2024
Closed
Closed
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 11, 2024

The fix is so trivial that I marked this for cherry-picking into 7.2.1, let me know if you think that's not a good idea.

@meteorcloudy
Copy link
Member

The fix is so trivial that I marked this for cherry-picking into 7.2.1, let me know if you think that's not a good idea.

SG, let's make 7.2.1 more valuable!

@keertk keertk added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 11, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 11, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jun 11, 2024
@fmeum @bazel-io
Treat missing repo boundary files as transient errors
de41264 
Fixes bazelbuild#22687

Closes bazelbuild#22700.

PiperOrigin-RevId: 642340825
Change-Id: I96f496b309c4740ae561f69098eca54a12a574f0
@bazel-io bazel-io mentioned this pull request Jun 11, 2024
Merged
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jun 11, 2024
@fmeum @bazel-io
Treat missing repo boundary files as transient errors
f0b6811 
Fixes bazelbuild#22687

Closes bazelbuild#22700.

PiperOrigin-RevId: 642340825
Change-Id: I96f496b309c4740ae561f69098eca54a12a574f0
@bazel-io bazel-io mentioned this pull request Jun 11, 2024
Merged
@fmeum fmeum deleted the 22687-boundary-file branch June 11, 2024 19:04
github-merge-queue bot pushed a commit that referenced this pull request Jun 11, 2024
@bazel-io @fmeum
[7.3.0] Treat missing repo boundary files as transient errors (#22708)
cc120b8 
Fixes #22687

Closes #22700.

PiperOrigin-RevId: 642340825
Change-Id: I96f496b309c4740ae561f69098eca54a12a574f0

Commit
b868a59

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
github-merge-queue bot pushed a commit that referenced this pull request Jun 11, 2024
@bazel-io @fmeum
[7.2.1] Treat missing repo boundary files as transient errors (#22707)
3097787 
Fixes #22687

Closes #22700.

PiperOrigin-RevId: 642340825
Change-Id: I96f496b309c4740ae561f69098eca54a12a574f0

Commit
b868a59

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@lberki lberki Awaiting requested review from lberki lberki is a code owner

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local_path_override doesn't get invalidated for MODULE.bazel file creation
3 participants
@fmeum @meteorcloudy @keertk