[7.4.0] Fix an NPE with the SkymeldUiStateTracker. #23495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A race condition can happen: - Thread 1: `#writeProgressBar` is called due to `LoadingPhaseStartedEvent`, expecting `buildStatus` to be `TARGET_PATTERN_PARSING` - Main thread: `LoadingPhaseCompleteEvent` arrives. **`buildStatus` is set to `LOADING_COMPLETE`**. additionalMessage is not yet updated and is still null. - Thread 1: Seeing that `buildStatus` is now `LOADING_COMPLETE`, it moves forward with that code path => NPE when `additionMessage` is checked. To fix this NPE, the CL made 2 changes: 1. Synchronize methods that touch `buildStatus` 2. Default `additionalMessage` to an empty string to make the code more robust. PiperOrigin-RevId: 640061798 Change-Id: I5034fe7692e0641559fb7666eec09cb554e09545
github-actions
bot
added
awaiting-review
meisterT
approved these changes
Sep 3, 2024
iancha1992
changed the title
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A race condition can happen:
#writeProgressBaris called due toLoadingPhaseStartedEvent, expectingbuildStatusto beTARGET_PATTERN_PARSINGLoadingPhaseCompleteEventarrives.buildStatusis set toLOADING_COMPLETE. additionalMessage is not yet updated and is still null.buildStatusis nowLOADING_COMPLETE, it moves forward with that code path => NPE whenadditionMessageis checked.To fix this NPE, the CL made 2 changes:
buildStatusadditionalMessageto an empty string to make the code more robust.PiperOrigin-RevId: 640061798
Change-Id: I5034fe7692e0641559fb7666eec09cb554e09545
#23484