-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidate lockfile entry when the extension name prefix changes #23527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Sep 5, 2024
This was missed in bazelbuild#19055.
fmeum
force-pushed
the
19055-invalidation
branch
from
September 5, 2024 15:19
83c87c3
to
11dcf0b
Compare
Wyverald
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
Wyverald
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Sep 5, 2024
@bazel-io fork 7.4.0 |
github-actions
bot
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Sep 9, 2024
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Sep 9, 2024
This was missed in bazelbuild#19055. Closes bazelbuild#23527. PiperOrigin-RevId: 672480631 Change-Id: Ib2ef0edb6b6c90a7336085da20e2794a93763182
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Sep 11, 2024
This was missed in bazelbuild#19055. Closes bazelbuild#23527. PiperOrigin-RevId: 672480631 Change-Id: Ib2ef0edb6b6c90a7336085da20e2794a93763182
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Sep 11, 2024
This was missed in bazelbuild#19055. Closes bazelbuild#23527. PiperOrigin-RevId: 672480631 Change-Id: Ib2ef0edb6b6c90a7336085da20e2794a93763182
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Sep 11, 2024
This was missed in bazelbuild#19055. Closes bazelbuild#23527. PiperOrigin-RevId: 672480631 Change-Id: Ib2ef0edb6b6c90a7336085da20e2794a93763182
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in #19055.