Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate lockfile entry when the extension name prefix changes #23527

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 5, 2024

This was missed in #19055.

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Sep 5, 2024
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 5, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 5, 2024

@bazel-io fork 7.4.0

@copybara-service copybara-service bot closed this in 926b574 Sep 9, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 9, 2024
@fmeum fmeum deleted the 19055-invalidation branch September 9, 2024 19:33
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Sep 9, 2024
This was missed in bazelbuild#19055.

Closes bazelbuild#23527.

PiperOrigin-RevId: 672480631
Change-Id: Ib2ef0edb6b6c90a7336085da20e2794a93763182
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Sep 11, 2024
This was missed in bazelbuild#19055.

Closes bazelbuild#23527.

PiperOrigin-RevId: 672480631
Change-Id: Ib2ef0edb6b6c90a7336085da20e2794a93763182
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Sep 11, 2024
This was missed in bazelbuild#19055.

Closes bazelbuild#23527.

PiperOrigin-RevId: 672480631
Change-Id: Ib2ef0edb6b6c90a7336085da20e2794a93763182
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Sep 11, 2024
This was missed in bazelbuild#19055.

Closes bazelbuild#23527.

PiperOrigin-RevId: 672480631
Change-Id: Ib2ef0edb6b6c90a7336085da20e2794a93763182
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2024
…ges (#23564)

This was missed in #19055.

Closes #23527.

PiperOrigin-RevId: 672480631
Change-Id: Ib2ef0edb6b6c90a7336085da20e2794a93763182

Commit
926b574

---------

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.4.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants