-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bazel's embedded JDK to 23 #23651
Conversation
In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500. s390x and ppc64le can only be updated to 22, Windows arm64 can switch to Zulu JDK 21.
cc @coeuvre as we talked about Loom performance testing with the most recent JDK used at Google |
@bazel-io fork 7.4.0 |
@fmeum Do you now how stable a new non-LTS JDK version usually is? I'm fine merging this at HEAD but do you see any risk of backporting it to 7.4.0? |
@meteorcloudy Non-LTS JDKs are generally as stable as LTS releases, they are just not maintained with patches for longer than 6 months. But I don't think we have cherry-picked JDK updates before anyway ;-) That said, I have seen some commits to keep it up-to-date with the more recent JDK used internally for Blaze. We should also cherry-pick those if necessary. @cushon @coeuvre Do you happen to recall which changes have been necessary to keep running with the latest JDK? |
There are already some failures in https://buildkite.com/bazel/bazel-bazel/builds/29313#019209b3-4de9-4d46-87ae-8f7a13a68db4 (Not sure why they are not caught in presubmit)
|
@fweikert looks like the presubmit skipped most of the tests: https://buildkite.com/bazel/google-bazel-presubmit/builds/83889, I think this is a known issue of bazel-diff? Can we add the |
*** Reason for rollback *** Broke Bazel postsubmit: #23651 (comment) *** Original change description *** Update Bazel's embedded JDK to 23 In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500. s390x and ppc64le can only be updated to 22, Windows arm64 can switch to Zulu JDK 21. Closes #23651. PiperOrigin-RevId: 676408630 Change-Id: Iffbb319c20127a3df72e4e29db248550ea328b51
In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500. s390x and ppc64le can only be updated to 22, Windows arm64 can switch to Zulu JDK 21. Closes #23651. PiperOrigin-RevId: 676335578 Change-Id: I991c65c6d0d44469401666d0b123a2de31804f02
*** Reason for rollback *** Broke Bazel postsubmit: #23651 (comment) *** Original change description *** Update Bazel's embedded JDK to 23 In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows `--watchfs` to handle a configurable number of changes to a watched path rather than maxing out at 500. s390x and ppc64le can only be updated to 22, Windows arm64 can switch to Zulu JDK 21. Closes #23651. PiperOrigin-RevId: 676408630 Change-Id: Iffbb319c20127a3df72e4e29db248550ea328b51
In addition to performance improvements, this JDK release contains a fix for https://bugs.openjdk.org/browse/JDK-8330077, which allows
--watchfs
to handle a configurable number of changes to a watched path rather than maxing out at 500.s390x and ppc64le can only be updated to 22, Windows arm64 can switch to Zulu JDK 21.