[8.0.0] Use backslashes in executable paths when remotely executing on Windows #24080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.bat` scripts can only be executed on Windows when their paths use backslashes, not forward slashes. For this reason, local execution carefully replaces forward slashes with backslashes in the executable of a `Spawn` when executing on Windows. This commit adds equivalent logic for the case of remote execution on Windows from any host: * Remote execution replaces forward slashes with backslashes in the first argument when executing on Windows. * Most calls to `PathFragment#getCallablePathString` are replaced with the new execution platform aware `getCallablePathStringForOs`. This affects test actions, in which various wrappers execute different executables (e.g. `--run_under` targets) and thus can have Bazel-controlled executable path strings in locations other than the `argv[0]`. Fixes bazelbuild#11636 Closes bazelbuild#23986. PiperOrigin-RevId: 689357323 Change-Id: Ifb842babc02c6d741d3b45914a5bf5c032204e2b
bazel-io
added
team-Configurability
meteorcloudy
approved these changes
Oct 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
bazelbuild:release-8.0.0
with commit Oct 28, 2024
57ce6a4
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.batscripts can only be executed on Windows when their paths use backslashes, not forward slashes. For this reason, local execution carefully replaces forward slashes with backslashes in the executable of aSpawnwhen executing on Windows.This commit adds equivalent logic for the case of remote execution on Windows from any host:
PathFragment#getCallablePathStringare replaced with the new execution platform awaregetCallablePathStringForOs. This affects test actions, in which various wrappers execute different executables (e.g.--run_undertargets) and thus can have Bazel-controlled executable path strings in locations other than theargv[0].Fixes #11636
Closes #23986.
PiperOrigin-RevId: 689357323
Change-Id: Ifb842babc02c6d741d3b45914a5bf5c032204e2b
Commit 9c90100