[8.0.0] Use backslashes in executable paths when remotely executing on Windows #24080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.bat
scripts can only be executed on Windows when their paths use backslashes, not forward slashes. For this reason, local execution carefully replaces forward slashes with backslashes in the executable of aSpawn
when executing on Windows.This commit adds equivalent logic for the case of remote execution on Windows from any host:
PathFragment#getCallablePathString
are replaced with the new execution platform awaregetCallablePathStringForOs
. This affects test actions, in which various wrappers execute different executables (e.g.--run_under
targets) and thus can have Bazel-controlled executable path strings in locations other than theargv[0]
.Fixes #11636
Closes #23986.
PiperOrigin-RevId: 689357323
Change-Id: Ifb842babc02c6d741d3b45914a5bf5c032204e2b
Commit 9c90100