Windows: add skeleton for Bash-less test wrapper #5784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit: - Add the not-yet-documented `--windows_native_test_wrapper` flag. This flag will guard the new feature and allow the Bazel team to roll out the feature gradually, as well as to deprecate the old test execution mechanism gradually. - Add a target for the native implementation of the test wrapper. - Hook up the test action creator logic to use the new binary, and add a test to assert this. See bazelbuild#5508 Change-Id: I980a1a88cfabd04ddcf8a5b26620f8f3255f77ef
laszlocsomor
requested review from
irengrig and
iirina
and removed request for
iirina
Change-Id: Ie14459506a1bfc2534c8d138771bf58c99f86f83
|
There are too many problems, and the fixes I'm piling up are making this PR unnecessarily complicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit:
Add the not-yet-documented
--windows_native_test_wrapperflag. This flagwill guard the new feature and allow the Bazel
team to roll out the feature gradually, as well
as to deprecate the old test execution mechanism
gradually.
Add a target for the native implementation of
the test wrapper.
Hook up the test action creator logic to use the
new binary, and add a test to assert this.
See #5508
Change-Id: I980a1a88cfabd04ddcf8a5b26620f8f3255f77ef