Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using --release in versioned java_toolchains #5982

Closed
wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Aug 24, 2018

Using --release to target versions that support modules and are not the
latest supported version (e.g. --release 9 on JDK 10) doesn't work:
https://bugs.openjdk.java.net/browse/JDK-8209865

Related: #5723

Using --release to target versions that support modules and are not the
latest supported version (e.g. --release 9 on JDK 10) doesn't work:
https://bugs.openjdk.java.net/browse/JDK-8209865

Related: bazelbuild#5723
Copy link
Member

@jin jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for android/

@jin jin added the team-Rules-Java Issues for Java rules label Aug 27, 2018
@bazel-io bazel-io closed this in 3987300 Aug 29, 2018
laurentlb pushed a commit that referenced this pull request Sep 7, 2018
Using --release to target versions that support modules and are not the
latest supported version (e.g. --release 9 on JDK 10) doesn't work:
https://bugs.openjdk.java.net/browse/JDK-8209865

Related: #5723

Closes #5982.

PiperOrigin-RevId: 210646978
laurentlb pushed a commit that referenced this pull request Sep 7, 2018
Using --release to target versions that support modules and are not the
latest supported version (e.g. --release 9 on JDK 10) doesn't work:
https://bugs.openjdk.java.net/browse/JDK-8209865

Related: #5723

Closes #5982.

PiperOrigin-RevId: 210646978
laurentlb pushed a commit that referenced this pull request Sep 10, 2018
Using --release to target versions that support modules and are not the
latest supported version (e.g. --release 9 on JDK 10) doesn't work:
https://bugs.openjdk.java.net/browse/JDK-8209865

Related: #5723

Closes #5982.

PiperOrigin-RevId: 210646978
laurentlb pushed a commit that referenced this pull request Sep 10, 2018
Using --release to target versions that support modules and are not the
latest supported version (e.g. --release 9 on JDK 10) doesn't work:
https://bugs.openjdk.java.net/browse/JDK-8209865

Related: #5723

Closes #5982.

PiperOrigin-RevId: 210646978
laurentlb pushed a commit that referenced this pull request Sep 12, 2018
Using --release to target versions that support modules and are not the
latest supported version (e.g. --release 9 on JDK 10) doesn't work:
https://bugs.openjdk.java.net/browse/JDK-8209865

Related: #5723

Closes #5982.

PiperOrigin-RevId: 210646978
laurentlb pushed a commit that referenced this pull request Sep 12, 2018
Using --release to target versions that support modules and are not the
latest supported version (e.g. --release 9 on JDK 10) doesn't work:
https://bugs.openjdk.java.net/browse/JDK-8209865

Related: #5723

Closes #5982.

PiperOrigin-RevId: 210646978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants