cc_configure: Remove hardcoded link option "-B/usr/bin" #6360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting -B/usr/bin on the link line breaks use of custom C/C++ toolchain
since support binaries such as ld, as, etc., will incorrectly "leak" to
the build machine.
Fixes #5634
Archeaology: It looks like this logic was originally added here:
810d60a Apr 22 2016 dmarting@google.com
"cc_configure: Add -B to compiler flag too"
.. and that that was done to get Tensor Flow building on some (but failing
on other?) versions of RedHat. #1152.
This may have also "fixed" the hombrew builds for
#1177.
Testing Done:
Building envoy on older Centos host using non-host
crosscompiler. Build fails without the fix and succeeds with the fix.
bazel test //src/test/java/com/google/devtools/build/lib:all
1 flaky test failed before and after:
bazel test //src/test/java/com/google/devtools/build/lib:vfs_test