Add flag to control native maven jar rule deprecation #6768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkelmer
requested review from
brandjon,
c-parsons,
dslomov,
laurentlb and
vladmos
as code owners
vladmos
reviewed
Nov 27, 2018
| @@ -476,6 +476,20 @@ | |||
| + "will be available") | |||
| public boolean incompatibleRemoveNativeHttpArchive; | |||
|
|
|||
| @Option( | |||
| name = "incompatible_remove_native_maven_jar", | |||
| defaultValue = "true", | |||
There was a problem hiding this comment.
AFAIK new flags should be added with the default value "false", this way people will be able to check whether their code is compatible with all the upcoming incompatible changes in advance.
| new EvalException( | ||
| null, | ||
| "The native maven_jar rule is deprecated." | ||
| + " add details about replacement here." |
|
Please follow Communicating Breaking Changes here (create flag with as off by default, file an issue tarcking migration) |
brandjon
approved these changes
Nov 27, 2018
|
Thanks for the review (everyone), I'm not sure why you all got added. I set the flag to true because I wanted to test against downstream dependencies. I'm going to address the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.