Windows: all JNI methods verify their path arg. #7178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laszlocsomor
force-pushed
the
fix-7173-followup
branch
from
ffb1d8c
to
910d871
Compare
Also remove the GetAttributesOfMaybeMissingFile method because it's based on a false belief, namely that FindFirstFile returns up-to-date information. According to this OldNewThing post that belief was wrong: https://blogs.msdn.microsoft.com/oldnewthing/20111226-00/?p=8813 This PR is a follow-up to bazelbuild#7176
laszlocsomor
force-pushed
the
fix-7173-followup
branch
from
910d871
to
cbe39cc
Compare
|
PTAL -- fixed the test failure and rebased on master. |
weixiao-huang
pushed a commit
to weixiao-huang/bazel
that referenced
this pull request
Jan 31, 2019
Also remove the GetAttributesOfMaybeMissingFile method because it's based on a false belief, namely that FindFirstFile returns up-to-date information. According to this OldNewThing post that belief was wrong: https://blogs.msdn.microsoft.com/oldnewthing/20111226-00/?p=8813 This PR is a follow-up to bazelbuild#7176 Closes bazelbuild#7178. PiperOrigin-RevId: 230705273
philwo
added
the
team-OSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the GetAttributesOfMaybeMissingFile
method because it's based on a false belief,
namely that FindFirstFile returns up-to-date
information. According to this OldNewThing post
that belief was wrong: https://blogs.msdn.microsoft.com/oldnewthing/20111226-00/?p=8813
This PR is a follow-up to #7176