Remove LcovMerger from tools/test:embedded_tools. #7412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but is it possible to have a test for this? It's very surprising that nothing is obviously broken with the old name (LcovMerger). |
lberki
approved these changes
Feb 13, 2019
|
I gave this more thought and figure out this is not the issue with #7279. So the line I was changing in this PR is useless so I just deleted it. |
iirina
changed the title
|
@lfpino ptal |
lberki
approved these changes
Feb 13, 2019
lfpino
approved these changes
Feb 13, 2019
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoverageOutputGeneratoris actually embedded intobazel_toolsthrough //tools:embedded_tools_srcs.The referenced changed in this PR is useless so I just deleted it.