Add first JUnit workspace black box test #7591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce test repository generator class: generates a directory with: helper.bzl with the "write_to_file" Starlark rule definition: the rule prints [parametrized by generation] text to a file; and the BUILD file with a target of "write_to_file" rule, and the pkg_tar target, which packs everything in this directory into a tar archive; so one can use this directory as a source for local_repository or produced tar archive as a source for http_archive with file:/// URI, and call some platform independent target from the generated repository. - have a test for test repository generator class - move one test from workspace_test.sh into WorkspaceBlackBoxTest.java The test is platform independent, as it uses zero shell scripts. To be continued, it is a part of verifying that bundled Starlark repository rules are working on Windows without msys/mingw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce test repository generator class: generates a directory with:
helper.bzl with the "write_to_file" Starlark rule definition:
the rule prints [parametrized by generation] text to a file;
and the BUILD file with a target of "write_to_file" rule,
and the pkg_tar target, which packs everything in this directory into
a tar archive;
so one can use this directory as a source for local_repository or
produced tar archive as a source for http_archive with file:/// URI,
and call some platform independent target from the generated repository.
have a test for test repository generator class
move one test from workspace_test.sh into WorkspaceBlackBoxTest.java
The test is platform independent, as it uses zero shell scripts.
To be continued, it is a part of verifying that bundled Starlark
repository rules are working on Windows without msys/mingw.