Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change uses of SplitTransitionProvider to TransitionFactory. #7833

Closed
wants to merge 5 commits into from
Closed

Change uses of SplitTransitionProvider to TransitionFactory. #7833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5fc444
Change uses of SplitTransitionProvider to TransitionFactory.
katre Mar 25, 2019
7521d81
Review fixes: add a precondition and fix a name
katre Mar 26, 2019
fdb9cf9
Make MultiArchSplitTransitionProvider note that it is a split factory…
katre Mar 26, 2019
5702061
Mark more things as split factories
katre Mar 26, 2019
fdc0b38
Removed extra 'a'
katre Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/com/google/devtools/build/lib/analysis/skylark/SkylarkAttr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@
import com.google.devtools.build.lib.analysis.config.HostTransition;
import com.google.devtools.build.lib.analysis.config.StarlarkDefinedConfigTransition;
import com.google.devtools.build.lib.analysis.config.transitions.SplitTransition;
import com.google.devtools.build.lib.analysis.config.transitions.TransitionFactory;
import com.google.devtools.build.lib.events.Location;
import com.google.devtools.build.lib.packages.Attribute;
import com.google.devtools.build.lib.packages.Attribute.AllowedValueSet;
import com.google.devtools.build.lib.packages.Attribute.ImmutableAttributeFactory;
import com.google.devtools.build.lib.packages.Attribute.SkylarkComputedDefaultTemplate;
import com.google.devtools.build.lib.packages.Attribute.SplitTransitionProvider;
import com.google.devtools.build.lib.packages.AttributeValueSource;
import com.google.devtools.build.lib.packages.BuildType;
import com.google.devtools.build.lib.packages.Provider;
Expand Down Expand Up @@ -252,7 +252,7 @@ && containsNonNoneKey(arguments, ALLOW_SINGLE_FILE_ARG)) {
Object trans = arguments.get(CONFIGURATION_ARG);
boolean isSplit =
trans instanceof SplitTransition
|| trans instanceof SplitTransitionProvider
|| trans instanceof TransitionFactory
|| trans instanceof StarlarkDefinedConfigTransition;
if (isSplit && defaultValue instanceof SkylarkLateBoundDefault) {
throw new EvalException(
Expand All @@ -273,8 +273,8 @@ && containsNonNoneKey(arguments, ALLOW_SINGLE_FILE_ARG)) {
builder.cfg(HostTransition.INSTANCE);
} else if (trans instanceof SplitTransition) {
builder.cfg((SplitTransition) trans);
} else if (trans instanceof SplitTransitionProvider) {
builder.cfg((SplitTransitionProvider) trans);
} else if (trans instanceof TransitionFactory) {
builder.cfg((TransitionFactory) trans);
} else if (trans instanceof StarlarkDefinedConfigTransition) {
StarlarkDefinedConfigTransition starlarkDefinedTransition =
(StarlarkDefinedConfigTransition) trans;
Expand Down
23 changes: 16 additions & 7 deletions ...a/com/google/devtools/build/lib/analysis/skylark/StarlarkAttributeTransitionProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,15 @@
import com.google.devtools.build.lib.analysis.config.BuildOptions;
import com.google.devtools.build.lib.analysis.config.StarlarkDefinedConfigTransition;
import com.google.devtools.build.lib.analysis.config.transitions.SplitTransition;
import com.google.devtools.build.lib.analysis.config.transitions.TransitionFactory;
import com.google.devtools.build.lib.events.Event;
import com.google.devtools.build.lib.packages.Attribute;
import com.google.devtools.build.lib.packages.Attribute.SplitTransitionProvider;
import com.google.devtools.build.lib.packages.AttributeMap;
import com.google.devtools.build.lib.packages.ConfiguredAttributeMapper;
import com.google.devtools.build.lib.packages.RuleTransitionData;
import com.google.devtools.build.lib.packages.StructImpl;
import com.google.devtools.build.lib.packages.StructProvider;
import com.google.devtools.build.lib.skylarkbuildapi.SplitTransitionProviderApi;
import com.google.devtools.build.lib.skylarkinterface.SkylarkPrinter;
import com.google.devtools.build.lib.syntax.Environment;
import com.google.devtools.build.lib.syntax.EvalException;
Expand All @@ -39,17 +41,18 @@
import java.util.List;

/**
* This class implements a {@link SplitTransitionProvider} to provide a starlark-defined transition
* that rules can apply to their dependencies' configurations. This transition has access to (1) the
* a map of the current configuration's build settings and (2) the configured attributes of the
* given rule (not its dependencies').
* This class implements {@link TransitionFactory} to provide a starlark-defined transition that
* rules can apply to their dependencies' configurations. This transition has access to (1) the a
katre marked this conversation as resolved.
Show resolved Hide resolved
* map of the current configuration's build settings and (2) the configured attributes of the given
* rule (not its dependencies').
*
* <p>For starlark defined rule class transitions, see {@link StarlarkRuleTransitionProvider}.
*
* <p>TODO(bazel-team): Consider allowing dependency-typed attributes to actually return providers
* instead of just labels (see {@link SkylarkAttributesCollection#addAttribute}).
*/
public class StarlarkAttributeTransitionProvider implements SplitTransitionProvider {
public class StarlarkAttributeTransitionProvider
implements TransitionFactory<RuleTransitionData>, SplitTransitionProviderApi {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename SplitTransitionProviderApi to TransitionFactoryApi. After all, the class is not a SplitTransitionProvider anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it up to @juliexxia whether to rename, she was discussing a future plan to separate starlark patch and split transitions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing to me too. What's the purpose of SplitTransitionProviderApi? It looks like just an empty interface to expose SplitTransitionProvider to Starlark? And what does it mean to say isSplit() is true below?

My understanding is this may or may not be a split. So for the scenarios where it isn't a split what do those words mean?

(I guess this is mostly a question for @juliexxia).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think how it stands makes sense for this PR. I can always do clean up later.

Currently all Starlark transitions attached to attributes (i.e., StarlarkAttributeTransitionProvider transitions) are natively treated like SplitTransitions. This isn't something that's exposed to the user (i.e. if you return a map instead of a map of maps, that works just fine), just something that was done so we didn't have to handle patch and split transitions here.

SplitTransitionProviderApi was originally introduced for the benefit of exposing MultiArchSplitTransitionProvider to Starlark. That's it's only use case other than this. So SplitTransitionProviderApi is still technically the truth. And TransitionFactory seems to obscure the difference between split and patch transitions - @katre as a catch up question, are those both going to fall under this? I think it's mostly important in regards to the restriction that split transitions can't be attached directly to rules.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, TransitionFactory can produce both PatchTransition or SplitTransition. I had considered making it generic in which type it returns (so the signature would become TransitionFactory<PatchTransition, RuleTransitionData>), but

  1. This ends up being cumbersome to use, and
  2. The actual usage would be that Attribute has TransitionFactory<?, RuleTransitionData> so the difference isn't meaningful.

Actual code that cares can check the value of TransitionFactory.isSplit to see if the factory thinks it's returning a SplitTransition or not.

private final StarlarkDefinedConfigTransition starlarkDefinedConfigTransition;

StarlarkAttributeTransitionProvider(
Expand All @@ -63,12 +66,18 @@ public StarlarkDefinedConfigTransition getStarlarkDefinedConfigTransitionForTest
}

@Override
public SplitTransition apply(AttributeMap attributeMap) {
public SplitTransition create(RuleTransitionData data) {
katre marked this conversation as resolved.
Show resolved Hide resolved
AttributeMap attributeMap = data.attributes();
Preconditions.checkArgument(attributeMap instanceof ConfiguredAttributeMapper);
return new FunctionSplitTransition(
starlarkDefinedConfigTransition, (ConfiguredAttributeMapper) attributeMap);
}

@Override
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this method used? Like I mentioned above, StarlarkAttributeTransitions are always SplitTransitions according to native code (for now, I suppose this distinction could be made more clear) but might not actually map to multiple output BuildOptions in practice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Callers of TransitionFactory that care whether the transition is a PatchTransition or a SplitTransition can use this to distinguish. It's about the return type and the intent, not on how many actual splits are produced.

Ideally at some point we should unify these further, but I'm not working on that immediately.

public boolean isSplit() {
return true;
}

@Override
public void repr(SkylarkPrinter printer) {
printer.append("<transition object>");
Expand Down
113 changes: 46 additions & 67 deletions src/main/java/com/google/devtools/build/lib/packages/Attribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,13 @@
import com.google.devtools.build.lib.analysis.config.transitions.NoTransition;
import com.google.devtools.build.lib.analysis.config.transitions.PatchTransition;
import com.google.devtools.build.lib.analysis.config.transitions.SplitTransition;
import com.google.devtools.build.lib.analysis.config.transitions.TransitionFactory;
import com.google.devtools.build.lib.cmdline.Label;
import com.google.devtools.build.lib.events.EventHandler;
import com.google.devtools.build.lib.events.Location;
import com.google.devtools.build.lib.packages.RuleClass.Builder.RuleClassNamePredicate;
import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec.VisibleForSerialization;
import com.google.devtools.build.lib.skylarkbuildapi.SplitTransitionProviderApi;
import com.google.devtools.build.lib.skylarkinterface.SkylarkPrinter;
import com.google.devtools.build.lib.syntax.ClassObject;
import com.google.devtools.build.lib.syntax.EvalException;
import com.google.devtools.build.lib.syntax.EvalUtils;
Expand Down Expand Up @@ -287,44 +286,6 @@ public String checkValid(Rule from, Rule to) {
}
};

/**
* Provides a {@link SplitTransition} given the originating target {@link Rule}. The split
* transition may be constant for all instances of the originating rule, or it may differ
* based on attributes of that rule. For instance, a split transition on a rule's deps may differ
* depending on the 'platform' attribute of the rule.
*/
public interface SplitTransitionProvider extends SplitTransitionProviderApi {
/**
* Returns the {@link SplitTransition} given the attribute mapper of the originating rule.
*/
SplitTransition apply(AttributeMap attributeMap);
}

/**
* Implementation of {@link SplitTransitionProvider} that returns a single {@link SplitTransition}
* regardless of the originating rule.
*/
@AutoCodec.VisibleForSerialization
@AutoCodec
static class BasicSplitTransitionProvider implements SplitTransitionProvider {
private final SplitTransition splitTransition;

@AutoCodec.VisibleForSerialization
BasicSplitTransitionProvider(SplitTransition splitTransition) {
this.splitTransition = splitTransition;
}

@Override
public SplitTransition apply(AttributeMap attributeMap) {
return splitTransition;
}

@Override
public void repr(SkylarkPrinter printer) {
printer.append("<transition object>");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do these get printed in Starlark with this method removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only starlark transitions need to be printed from Starlark, and they all implement SplitTransitionProviderApi (and so have a repr method).

}
}

/** A predicate class to check if the value of the attribute comes from a predefined set. */
@AutoCodec
public static class AllowedValueSet implements PredicateWithMessage<Object> {
Expand Down Expand Up @@ -393,7 +354,8 @@ public static class ImmutableAttributeFactory {
private final ConfigurationTransition configTransition;
private final RuleClassNamePredicate allowedRuleClassesForLabels;
private final RuleClassNamePredicate allowedRuleClassesForLabelsWarning;
private final SplitTransitionProvider splitTransitionProvider;
// TODO(https://github.com/bazelbuild/bazel/issues/7814): Merge this with configTransition.
private final TransitionFactory<RuleTransitionData> splitTransitionFactory;
private final FileTypeSet allowedFileTypesForLabels;
private final ValidityPredicate validityPredicate;
private final Object value;
Expand All @@ -414,7 +376,7 @@ public static class ImmutableAttributeFactory {
ConfigurationTransition configTransition,
RuleClassNamePredicate allowedRuleClassesForLabels,
RuleClassNamePredicate allowedRuleClassesForLabelsWarning,
SplitTransitionProvider splitTransitionProvider,
TransitionFactory<RuleTransitionData> splitTransitionFactory,
FileTypeSet allowedFileTypesForLabels,
ValidityPredicate validityPredicate,
AttributeValueSource valueSource,
Expand All @@ -428,7 +390,7 @@ public static class ImmutableAttributeFactory {
this.configTransition = configTransition;
this.allowedRuleClassesForLabels = allowedRuleClassesForLabels;
this.allowedRuleClassesForLabelsWarning = allowedRuleClassesForLabelsWarning;
this.splitTransitionProvider = splitTransitionProvider;
this.splitTransitionFactory = splitTransitionFactory;
this.allowedFileTypesForLabels = allowedFileTypesForLabels;
this.validityPredicate = validityPredicate;
this.value = value;
Expand All @@ -453,7 +415,7 @@ public Attribute build(String name) {
Preconditions.checkState(!name.isEmpty(), "name has not been set");
if (valueSource == AttributeValueSource.LATE_BOUND) {
Preconditions.checkState(isLateBound(name));
Preconditions.checkState(splitTransitionProvider == null);
Preconditions.checkState(splitTransitionFactory == null);
}
// TODO(bazel-team): Set the default to be no file type, then remove this check, and also
// remove all allowedFileTypes() calls without parameters.
Expand All @@ -480,7 +442,7 @@ public Attribute build(String name) {
propertyFlags,
value,
configTransition,
splitTransitionProvider,
splitTransitionFactory,
allowedRuleClassesForLabels,
allowedRuleClassesForLabelsWarning,
allowedFileTypesForLabels,
Expand All @@ -504,7 +466,8 @@ public static class Builder <TYPE> {
private ConfigurationTransition configTransition = NoTransition.INSTANCE;
private RuleClassNamePredicate allowedRuleClassesForLabels = ANY_RULE;
private RuleClassNamePredicate allowedRuleClassesForLabelsWarning = NO_RULE;
private SplitTransitionProvider splitTransitionProvider;
// TODO(https://github.com/bazelbuild/bazel/issues/7814): Merge this with configTransition.
private TransitionFactory<RuleTransitionData> splitTransitionFactory;
private FileTypeSet allowedFileTypesForLabels;
private ValidityPredicate validityPredicate = ANY_EDGE;
private Object value;
Expand Down Expand Up @@ -637,14 +600,16 @@ public Builder<TYPE> hasAnalysisTestTransition() {
"analysis-test split transition");
}

/**
* Defines the configuration transition for this attribute.
*/
public Builder<TYPE> cfg(SplitTransitionProvider splitTransitionProvider) {
/** Defines the configuration transition for this attribute. */
// TODO(https://github.com/bazelbuild/bazel/issues/7814): Currently only for split transitions.
public Builder<TYPE> cfg(TransitionFactory<RuleTransitionData> splitTransitionFactory) {
Preconditions.checkState(this.configTransition == NoTransition.INSTANCE,
"the configuration transition is already set");
Preconditions.checkState(
splitTransitionFactory.isSplit(),
"cfg(TransitionFactory) is only valid for split transitions at this time.");

this.splitTransitionProvider = Preconditions.checkNotNull(splitTransitionProvider);
this.splitTransitionFactory = Preconditions.checkNotNull(splitTransitionFactory);
katre marked this conversation as resolved.
Show resolved Hide resolved
return this;
}

Expand All @@ -657,7 +622,18 @@ public Builder<TYPE> cfg(ConfigurationTransition configTransition) {
Preconditions.checkState(this.configTransition == NoTransition.INSTANCE,
"the configuration transition is already set");
if (configTransition instanceof SplitTransition) {
return cfg(new BasicSplitTransitionProvider((SplitTransition) configTransition));
return cfg(
new TransitionFactory<RuleTransitionData>() {
@Override
public ConfigurationTransition create(RuleTransitionData data) {
return configTransition;
}

@Override
public boolean isSplit() {
return true;
}
});
} else {
this.configTransition = configTransition;
return this;
Expand Down Expand Up @@ -1200,7 +1176,7 @@ public ImmutableAttributeFactory buildPartial() {
configTransition,
allowedRuleClassesForLabels,
allowedRuleClassesForLabelsWarning,
splitTransitionProvider,
splitTransitionFactory,
allowedFileTypesForLabels,
validityPredicate,
valueSource,
Expand Down Expand Up @@ -1951,7 +1927,8 @@ public static LabelListLateBoundDefault<Void> fromRuleAndAttributesOnly(

private final ConfigurationTransition configTransition;

private final SplitTransitionProvider splitTransitionProvider;
// TODO(https://github.com/bazelbuild/bazel/issues/7814): Merge this with configTransition.
private final TransitionFactory<RuleTransitionData> splitTransitionFactory;

/**
* For label or label-list attributes, this predicate returns which rule
Expand Down Expand Up @@ -2009,7 +1986,7 @@ public static LabelListLateBoundDefault<Void> fromRuleAndAttributesOnly(
Set<PropertyFlag> propertyFlags,
Object defaultValue,
ConfigurationTransition configTransition,
SplitTransitionProvider splitTransitionProvider,
TransitionFactory<RuleTransitionData> splitTransitionFactory,
RuleClassNamePredicate allowedRuleClassesForLabels,
RuleClassNamePredicate allowedRuleClassesForLabelsWarning,
FileTypeSet allowedFileTypesForLabels,
Expand Down Expand Up @@ -2041,7 +2018,7 @@ public static LabelListLateBoundDefault<Void> fromRuleAndAttributesOnly(
this.propertyFlags = propertyFlags;
this.defaultValue = defaultValue;
this.configTransition = configTransition;
this.splitTransitionProvider = splitTransitionProvider;
this.splitTransitionFactory = splitTransitionFactory;
this.allowedRuleClassesForLabels = allowedRuleClassesForLabels;
this.allowedRuleClassesForLabelsWarning = allowedRuleClassesForLabelsWarning;
this.allowedFileTypesForLabels = allowedFileTypesForLabels;
Expand All @@ -2058,7 +2035,7 @@ public static LabelListLateBoundDefault<Void> fromRuleAndAttributesOnly(
propertyFlags,
defaultValue,
configTransition,
splitTransitionProvider,
splitTransitionFactory,
allowedRuleClassesForLabels,
allowedRuleClassesForLabelsWarning,
allowedFileTypesForLabels,
Expand Down Expand Up @@ -2187,20 +2164,22 @@ public ConfigurationTransition getConfigurationTransition(AttributeMap usused) {
*/
public SplitTransition getSplitTransition(AttributeMap attributeMapper) {
Preconditions.checkState(hasSplitConfigurationTransition());
return splitTransitionProvider.apply(attributeMapper);
return (SplitTransition)
splitTransitionFactory.create(RuleTransitionData.create(attributeMapper));
}

// TODO(https://github.com/bazelbuild/bazel/issues/7814): Remove this.
@VisibleForTesting
public SplitTransitionProvider getSplitTransitionProviderForTesting() {
return splitTransitionProvider;
public TransitionFactory<RuleTransitionData> getSplitTransitionProviderForTesting() {
return splitTransitionFactory;
}

/**
* Returns true if this attribute transitions on a split transition. See {@link SplitTransition}.
*/
// TODO(https://github.com/bazelbuild/bazel/issues/7814) Remove this.
public boolean hasSplitConfigurationTransition() {
return (splitTransitionProvider != null);
return (splitTransitionFactory != null);
}

/**
Expand Down Expand Up @@ -2288,11 +2267,11 @@ public Predicate<RuleClass> getAllowedRuleClassesPredicate() {
}

/**
* Returns a predicate that evaluates to true for rule classes that are
* allowed labels in this attribute. If this is not a label or label-list
* attribute, the returned predicate always evaluates to true.
* Returns a predicate that evaluates to true for rule classes that are allowed labels in this
* attribute. If this is not a label or label-list attribute, the returned predicate always
* evaluates to true.
*/
// TODO(b/69917891) Remove these methods once checkbuilddeps no longer depends on them.
// TODO(b/69917891): Remove these methods once checkbuilddeps no longer depends on them.
public Predicate<String> getAllowedRuleClassNamesPredicate() {
return allowedRuleClassesForLabels.asPredicateOfRuleClassName();
}
Expand Down Expand Up @@ -2476,7 +2455,7 @@ public boolean equals(Object o) {
&& Objects.equals(propertyFlags, attribute.propertyFlags)
&& Objects.equals(defaultValue, attribute.defaultValue)
&& Objects.equals(configTransition, attribute.configTransition)
&& Objects.equals(splitTransitionProvider, attribute.splitTransitionProvider)
&& Objects.equals(splitTransitionFactory, attribute.splitTransitionFactory)
&& Objects.equals(allowedRuleClassesForLabels, attribute.allowedRuleClassesForLabels)
&& Objects.equals(
allowedRuleClassesForLabelsWarning, attribute.allowedRuleClassesForLabelsWarning)
Expand Down Expand Up @@ -2507,7 +2486,7 @@ public <TYPE> Attribute.Builder<TYPE> cloneBuilder(Type<TYPE> tp) {
builder.validityPredicate = validityPredicate;
builder.condition = condition;
builder.configTransition = configTransition;
builder.splitTransitionProvider = splitTransitionProvider;
builder.splitTransitionFactory = splitTransitionFactory;
builder.propertyFlags = newEnumSet(propertyFlags, PropertyFlag.class);
builder.value = defaultValue;
builder.valueSet = false;
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/google/devtools/build/lib/rules/objc/AppleSkylarkCommon.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder;
import com.google.devtools.build.lib.collect.nestedset.Order;
import com.google.devtools.build.lib.events.Location;
import com.google.devtools.build.lib.packages.Attribute.SplitTransitionProvider;
import com.google.devtools.build.lib.packages.NativeProvider;
import com.google.devtools.build.lib.packages.Provider;
import com.google.devtools.build.lib.packages.RuleClass.ConfiguredTargetFactory.RuleErrorException;
Expand All @@ -44,6 +43,7 @@
import com.google.devtools.build.lib.rules.objc.ObjcProvider.Key;
import com.google.devtools.build.lib.skylarkbuildapi.FileApi;
import com.google.devtools.build.lib.skylarkbuildapi.SkylarkRuleContextApi;
import com.google.devtools.build.lib.skylarkbuildapi.SplitTransitionProviderApi;
import com.google.devtools.build.lib.skylarkbuildapi.apple.AppleCommonApi;
import com.google.devtools.build.lib.skylarkinterface.SkylarkValue;
import com.google.devtools.build.lib.syntax.Environment;
Expand Down Expand Up @@ -175,7 +175,7 @@ public ImmutableMap<String, String> getTargetAppleEnvironment(
}

@Override
public SplitTransitionProvider getMultiArchSplitProvider() {
public SplitTransitionProviderApi getMultiArchSplitProvider() {
return new MultiArchSplitTransitionProvider();
}

Expand Down
Loading