Windows: fix native test wrapper's arg. escaping #7957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. Fixes bazelbuild#7956 Unblocks bazelbuild#6622
laszlocsomor
changed the title
laszlocsomor
changed the title
meteorcloudy
approved these changes
Apr 8, 2019
dkelmer
pushed a commit
that referenced
this pull request
Apr 11, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this pull request
Apr 16, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this pull request
Apr 25, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this pull request
Apr 25, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this pull request
Apr 25, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this pull request
Apr 26, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
dkelmer
pushed a commit
that referenced
this pull request
Apr 29, 2019
The native test wrapper now correctly escapes the arguments for the subprocess, using bazel::launcher::WindowsEscapeArg2 from the native launcher. The test_wrapper_test now uses a mock C++ binary instead of a .bat file to verify the test arguments. Doing so trades the weird command line flag parsing logic of cmd.exe (inherent in using a .bat file) for the saner C++ flag parsing one. Fixes #7956 Unblocks #6622 Closes #7957. PiperOrigin-RevId: 242446422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native test wrapper now correctly escapes the
arguments for the subprocess, using
bazel::launcher::WindowsEscapeArg2 from the native
launcher.
The test_wrapper_test now uses a mock C++ binary
instead of a .bat file to verify the test
arguments. Doing so trades the weird command line
flag parsing logic of cmd.exe (inherent in using a
.bat file) for the saner C++ flag parsing one.
Fixes #7956
Unblocks #6622