Windows, python: add inc. flag to fix escaping #7973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See bazelbuild#7958 RELNOTES[NEW]: Windows, Python: the --incompatible_windows_escape_python_args flag (false by default) builds py_binary and py_test targets with correct command line argument escaping. Change-Id: I789f9370e2cf59fa1a179716ca1c6ad80e1d583e
laszlocsomor
changed the title
|
/cc @brandjon (I'll be travelling this week so I won't be able to do this review) |
|
Thanks Lukács. No worries. I didn't expect your review, GitHub added you automatically. |
|
Looks cool. |
laszlocsomor
added a commit
to laszlocsomor/bazel
that referenced
this pull request
May 10, 2019
Follow-up to PR bazelbuild#7973 Copy the --incompatible_windows_escape_python_args value also to the host config options. Incompatible flag: bazelbuild#7974 See bazelbuild#7958
bazel-io
pushed a commit
that referenced
this pull request
May 10, 2019
aehlig
pushed a commit
that referenced
this pull request
May 13, 2019
aehlig
pushed a commit
that referenced
this pull request
May 17, 2019
aehlig
pushed a commit
that referenced
this pull request
May 17, 2019
aehlig
pushed a commit
that referenced
this pull request
May 20, 2019
aehlig
pushed a commit
that referenced
this pull request
May 21, 2019
aehlig
pushed a commit
that referenced
this pull request
May 22, 2019
aehlig
pushed a commit
that referenced
this pull request
May 23, 2019
aehlig
pushed a commit
that referenced
this pull request
May 23, 2019
aehlig
pushed a commit
that referenced
this pull request
May 24, 2019
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
Follow-up to PR bazelbuild#7973 Copy the --incompatible_windows_escape_python_args value also to the host config options. Incompatible flag: bazelbuild#7974 See bazelbuild#7958 Closes bazelbuild#8289. PiperOrigin-RevId: 247596101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incompatible flag: #7974
See #7958
RELNOTES[NEW]: Windows, Python: the --incompatible_windows_escape_python_args flag (false by default) builds py_binary and py_test targets with correct command line argument escaping.
Change-Id: I789f9370e2cf59fa1a179716ca1c6ad80e1d583e