Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix discard_graph_edges_test to properly depend on $(JAVABASE) #8037

Closed
wants to merge 3 commits into from
Closed

fix discard_graph_edges_test to properly depend on $(JAVABASE) #8037

wants to merge 3 commits into from

Conversation

buchgr
Copy link
Contributor

@buchgr buchgr commented Apr 15, 2019

  • no longer uses $bazel_javabase from testenv.sh
  • works with absolute $(JAVABASE) paths and JDK's other than loc

Progress towards #8033

@buchgr
fix discard_graph_edges_test to properly depend on $(JAVABASE)
9b2432e 
- no longer uses $bazel_javabase from testenv.sh
- works with absolute $(JAVABASE) paths and JDK's other than loc

Progress towards bazelbuild#8033
@buchgr buchgr requested a review from laszlocsomor April 15, 2019 11:12
@buchgr buchgr mentioned this pull request Apr 15, 2019
Open
26 tasks
@bazel-io bazel-io closed this in aadf364 Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laszlocsomor laszlocsomor laszlocsomor approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buchgr @laszlocsomor @googlebot