Check for both :lcov_merger and $lcov_merger attributes in TestActionBuilder. #8709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iirina
changed the title
scentini
approved these changes
Jun 24, 2019
laurentlb
pushed a commit
that referenced
this pull request
Jun 27, 2019
…Builder. 384e1cb renamed an attribute from `$lcov_merger` to `:lcov_merger`, which is a breaking change and broke rules_go. This PR changes the test runner to check both attribute names for backwards compatibility. The next step is to introduce an incompatible flag to remove the former. Fixes #8670 Closes #8709. PiperOrigin-RevId: 254915099
siberex
pushed a commit
to siberex/bazel
that referenced
this pull request
Jul 4, 2019
…Builder. 384e1cb renamed an attribute from `$lcov_merger` to `:lcov_merger`, which is a breaking change and broke rules_go. This PR changes the test runner to check both attribute names for backwards compatibility. The next step is to introduce an incompatible flag to remove the former. Fixes bazelbuild#8670 Closes bazelbuild#8709. PiperOrigin-RevId: 254915099
laurentlb
pushed a commit
that referenced
this pull request
Jul 8, 2019
…Builder. 384e1cb renamed an attribute from `$lcov_merger` to `:lcov_merger`, which is a breaking change and broke rules_go. This PR changes the test runner to check both attribute names for backwards compatibility. The next step is to introduce an incompatible flag to remove the former. Fixes #8670 Closes #8709. PiperOrigin-RevId: 254915099
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
…Builder. 384e1cb renamed an attribute from `$lcov_merger` to `:lcov_merger`, which is a breaking change and broke rules_go. This PR changes the test runner to check both attribute names for backwards compatibility. The next step is to introduce an incompatible flag to remove the former. Fixes bazelbuild#8670 Closes bazelbuild#8709. PiperOrigin-RevId: 254915099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
384e1cb renamed an attribute from
$lcov_mergerto:lcov_merger, which is a breaking change and broke rules_go. This PR changes the test runner to check both attribute names for backwards compatibility. The next step is to introduce an incompatible flag to remove the former.Fixes #8670