Flip --incompatible_load_proto_rules_from_bzl #8987
Conversation
|
Huh, this is scary (just like all the other "force load rule from .bzl file" changes). I'd love to know what downstream projects this breaks, but for some reason, BuildKite is not telling :( |
|
I think downstream testing only works for brances directly in the Bazel repo https://github.com/bazelbuild/continuous-integration/blob/master/docs/downstream-testing.md. |
|
...but the flag is already available at Bazel HEAD. Actually, I think I know now: our incompatible change testing pipeline only considers flags that are released (which this flag is not) Alas, yes, it will break most of the downstream projects. I expect the same for the Java and C++ versions, too. I don't have a good plan about tackling that... |
DO NOT SUBMIT until Bazel 0.29 was cut. RELNOTES: The flag --incompatible_load_proto_rules_from_bzl from_bzl has been flipped. Fixes bazelbuild#8922
|
What's the state of this PR? |
|
The state of this is "Won't flip this flag for Bazel 4.0" https://docs.google.com/spreadsheets/d/1hahSlNA9E-SXZckoVWnNkE2jwbX6MZpjTjgsfKSmAyk/edit?disco=AAAAJtxFoNo I'll close this for now and send a new one once the flag is ready to flip. |
DO NOT SUBMIT until Bazel 0.29 was cut.
RELNOTES: The flag --incompatible_load_proto_rules_from_bzl from_bzl has been flipped.
Fixes #8922