Streamline uploading of stdout and stderr #9025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes extra upload logic for stdout/stderr. Besides the streamlined code this also saves two round trips uploading an action that produced both stdout and stderr.
bazel-io
pushed a commit
that referenced
this pull request
Aug 5, 2019
*** Reason for rollback *** Probably the culprit that broke Windows builds with remote caching: #9072 *** Original change description *** Streamline uploading of stdout and stderr This change removes extra upload logic for stdout/stderr. Besides the streamlined code this also saves two round trips uploading an action that produced both stdout and stderr. Closes #9025. PiperOrigin-RevId: 261700869
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes extra upload logic for stdout/stderr. Besides
the streamlined code this also saves two round trips uploading an
action that produced both stdout and stderr.