Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add "Updating Bazel" link on master or > 0.28 docs. #9057

Closed
wants to merge 3 commits into from

Conversation

dslomov
Copy link
Contributor

@dslomov dslomov commented Aug 2, 2019

Fixes #9056.

@dslomov dslomov requested a review from aiuto as a code owner August 2, 2019 09:22
@dslomov dslomov removed the request for review from aiuto August 2, 2019 09:22
@dslomov
Copy link
Contributor Author

dslomov commented Aug 2, 2019

Principled fix would be versioning of _layouts/documentation.html, but it is more work and I have no quick idea how to start with that.

Copy link
Contributor

@laszlocsomor laszlocsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@bazel-io bazel-io closed this in 5f2b552 Aug 2, 2019
@jin
Copy link
Member

jin commented Aug 2, 2019

The versioning problem of _layouts.documentation.html is tracked in #6937. This seems like a good workaround for versioning the sidebar until we find a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Updating Bazel" link on https://docs.bazel.build/versions/0.28.0/bazel-overview.html 404s
4 participants